add token supply query #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2022
|
About that non-exhaustive issue: In newer versions of let mut res = SupplyResponse::default();
res.amount = amount; |
|
What is left to fix here? I'm blocked on this, happy to finish up the PR. |
chipshort
reviewed
Aug 14, 2023
Comment on lines
+31
to
+40
| // TODO: remove this when I figure out how non_exhaustive works | ||
| #[cfg(feature = "cosmwasm_1_1")] | ||
| #[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq, JsonSchema)] | ||
| #[serde(rename_all = "snake_case")] | ||
| pub struct SupplyResponse { | ||
| /// Always returns a Coin with the requested denom. | ||
| /// This will be of zero amount if the denom does not exist. | ||
| pub amount: Coin, | ||
| } | ||
|
|
There was a problem hiding this comment.
cosmwasm-std version should be bumped and then this can be removed. Instead the SupplyResponse from cosmwasm-std should be used (using either the Default impl or the recently introduced constructor)
| fn get_supply(&self, bank_storage: &dyn Storage, denom: String) -> AnyResult<Coin> { | ||
| let supply: Uint128 = BALANCES | ||
| .range(bank_storage, None, None, Order::Ascending) | ||
| .into_iter() |
There was a problem hiding this comment.
No need to call into_iter() here, it's a noop
| let supply: Uint128 = BALANCES | ||
| .range(bank_storage, None, None, Order::Ascending) | ||
| .into_iter() | ||
| .map(|a| a.unwrap().1) |
There was a problem hiding this comment.
I'm not a big fan of this unwrap, the error should be bubbled up
ghost
closed this by deleting the head repository
JakeHartnell
pushed a commit
to JakeHartnell/cw-multi-test
that referenced
this pull request
Aug 17, 2023
Builds off: CosmWasm#17
JakeHartnell
pushed a commit
to JakeHartnell/cw-multi-test
that referenced
this pull request
Aug 17, 2023
Builds off: CosmWasm#17
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty much self explanatory, I need to be able to query for the supply of a native token during testing.
I don't know how to get around the
non_exhaustiveissue, that's why I've redefined theSupplyResponsestruct.