Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds BankQuery::Supply support #51

Merged
merged 3 commits into from
Aug 21, 2023
Merged

Adds BankQuery::Supply support #51

merged 3 commits into from
Aug 21, 2023

Conversation

JakeHartnell
Copy link
Contributor

Builds off: #17

@JakeHartnell
Copy link
Contributor Author

@chipshort please have a look! 🙏

@JakeHartnell JakeHartnell mentioned this pull request Aug 18, 2023
Closed
@chipshort chipshort self-requested a review August 18, 2023 06:41
chipshort
chipshort reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this. Let's avoid that unwrap, then we can get this in.

src/bank.rs Outdated Show resolved Hide resolved
src/bank.rs Show resolved Hide resolved
@JakeHartnell
Copy link
Contributor Author

@chipshort, have another look! No unwrap, and added a test case for total supply with multiple accounts.

chipshort
chipshort approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chipshort chipshort merged commit ce37144 into CosmWasm:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipshort chipshort chipshort approved these changes

Assignees

@JakeHartnell JakeHartnell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeHartnell @chipshort