Range with no prefix support #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ueco-jb
reviewed
Sep 19, 2021
ethanfrey
reviewed
Sep 19, 2021
maurolacy
force-pushed
the
range-no-prefix
branch
from
6d54b2c to
3dd1f8d
Compare
ethanfrey
reviewed
Sep 19, 2021
There was a problem hiding this comment.
Looks quite nice. Except for removing all the #[cfg(feature = "iterator")] everywhere.
Not sure how we can disable iterator (default) in cosmwasm-storage unless it is explicitly set. We should try to at least build the code without iterator enabled and ensure this works.
|
Please rebase on #438 (maybe after merge?) and fix any CI failures (due to iterator) before merge. |
maurolacy
force-pushed
the
range-no-prefix
branch
from
13eedee to
5468556
Compare
Remove NoPrefix trait
maurolacy
force-pushed
the
range-no-prefix
branch
from
5468556 to
5010b07
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds aJust force the empty prefix inNoPrefixassociated type, to use forrange()short-cuts inMapalong with theEmptyPrefixmarker.Map::range.This type was missing from the impl. Adding it basically allows the added test case, where we iterate over a triple key without a prefix.Removed it altogether for simplicity.Can be reviewed / merged independently of #432. Already integrated in #432 branch.