Test storage-plus with iterator disabled #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
approved these changes
Sep 19, 2021
|
Damn, I rebased all of my MRs on top of the version without iterator flags. :-/ Will have to manually introduce these changes again, in each of the branches. |
Perhaps it will be better to delay merging this right now, and do it only after merging the deserialization stuff. Anyway, just an idea. We'll sort it out anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially for storage-plus.
It seems some code fails already. It would be good to also make iterator optional for any other package that doesn't require it (I think that is most of the packages except multitest, but none of the contracts)