Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cw3 fixed multisig #91

Merged
merged 37 commits into from
Sep 28, 2020
Merged

Cw3 fixed multisig #91

merged 37 commits into from
Sep 28, 2020

Conversation

ethanfrey
Copy link
Member

@ethanfrey ethanfrey commented Sep 15, 2020 •
edited
Loading

Closes #8

Status:

  • Init completed
  • Handle logic done (minus events/data on result)
  • Query logic done

TODO:

  • Write unit tests
  • Return info on HandleResult (data, logs)
  • Write proper README

@ethanfrey ethanfrey requested review from maurolacy and removed request for maurolacy September 22, 2020 22:43
@ethanfrey
Copy link
Member Author

@maurolacy this is a super rough draft, but if you want to take a quick look and let me know if I forgot any error cases or such, please do so.

maurolacy
maurolacy reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good to me.

contracts/cw3-fixed-multisig/src/contract.rs Show resolved Hide resolved
contracts/cw3-fixed-multisig/src/contract.rs Show resolved Hide resolved
contracts/cw3-fixed-multisig/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw3-fixed-multisig/src/contract.rs Show resolved Hide resolved
contracts/cw3-fixed-multisig/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw3-fixed-multisig/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw3-fixed-multisig/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw3-fixed-multisig/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw3-fixed-multisig/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw3-fixed-multisig/src/contract.rs Outdated Show resolved Hide resolved
@ethanfrey
Copy link
Member Author

Thanks for the feedback. I will update the spec in some places, code in others

@ethanfrey ethanfrey marked this pull request as ready for review September 23, 2020 22:14
@ethanfrey
Copy link
Member Author

@maurolacy I think I finished all logic and updated it with your feedback

When you have time, can you start writing some unit tests (also for the logic I added in cw0)? Just make a branch and push the commits when you finish them. I will merge them in and add some more tests myself possibly. Thanks

@orkunkl orkunkl mentioned this pull request Sep 26, 2020
Closed
1 task
orkunkl
orkunkl reviewed Sep 26, 2020
View reviewed changes
contracts/cw3-fixed-multisig/Cargo.toml
library = []

[dependencies]
cosmwasm-std = { version = "0.10.1", features = ["iterator"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added task migration to issue #96

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, better to do that in another MR in my opinion.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let us merge this first (and the nft contract) before migrating to 0.11.

For contract obligations, I need #97 and would like this PR to be merged (0.10.x compatible) before end of month, and published as 0.2.2. Once those are merged, let's get the 0.11 branch going and prepare a 0.3.0 release.

@ethanfrey
Copy link
Member Author

I just gotta fix up the readme, then this is ready for merge. Last reviews welcome

@ethanfrey ethanfrey merged commit 674a3f7 into master Sep 28, 2020
@ethanfrey ethanfrey deleted the cw3-fixed-multisig branch September 28, 2020 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy left review comments

@orkunkl orkunkl orkunkl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Basic multisig contract
3 participants
@ethanfrey @orkunkl @maurolacy