-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch back workspace-optimizer to Rust stable #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
reviewed
Apr 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it is worth the effort to get rid of the nightly Rust version.
Separate building from optimizing artifacts
maurolacy
force-pushed
the
workspace-optmimizer-avoid-nightly
branch
from
April 7, 2021 16:04
f5b350d
to
037e909
Compare
Remove existing artifacts before building
maurolacy
force-pushed
the
workspace-optmimizer-avoid-nightly
branch
from
April 7, 2021 16:15
037e909
to
15824ea
Compare
webmaster128
reviewed
Apr 7, 2021
maurolacy
force-pushed
the
workspace-optmimizer-avoid-nightly
branch
from
April 7, 2021 18:35
0c8a8fc
to
6cf7c2a
Compare
webmaster128
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the need of Rust nightly and the extra
rustup
install, by separating building from optimizing artifacts.Closes #34.