Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back workspace-optimizer to Rust stable #37

Merged
merged 6 commits into from
Apr 7, 2021

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Apr 7, 2021

Avoids the need of Rust nightly and the extra rustup install, by separating building from optimizing artifacts.

Closes #34.

@maurolacy maurolacy requested a review from webmaster128 April 7, 2021 11:46
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think it is worth the effort to get rid of the nightly Rust version.

optimize_workspace.sh Show resolved Hide resolved
optimize_workspace.sh Outdated Show resolved Hide resolved
optimize_workspace.sh Show resolved Hide resolved
Separate building from optimizing artifacts
@maurolacy maurolacy force-pushed the workspace-optmimizer-avoid-nightly branch from f5b350d to 037e909 Compare April 7, 2021 16:04
Remove existing artifacts before building
@maurolacy maurolacy force-pushed the workspace-optmimizer-avoid-nightly branch from 037e909 to 15824ea Compare April 7, 2021 16:15
optimize_workspace.sh Show resolved Hide resolved
optimize_workspace.sh Show resolved Hide resolved
@maurolacy maurolacy force-pushed the workspace-optmimizer-avoid-nightly branch from 0c8a8fc to 6cf7c2a Compare April 7, 2021 18:35
@webmaster128 webmaster128 merged commit ff0b746 into master Apr 7, 2021
@webmaster128 webmaster128 deleted the workspace-optmimizer-avoid-nightly branch April 7, 2021 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid the use of rustup
2 participants