Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos stargate tracking branch #172

Closed
wants to merge 21 commits into from
Closed

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Jul 3, 2020

Known problems:

  • wasmcli tx send fails with github.com/cosmos/cosmos-sdk/client.GetFromFields nil issue

TODO

  • wasmd start command fails with an decoding issue when parsing genesis watch sdk#6837
  • check/fix tx send

May add

  • LCD and CLI tests

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alpe alpe requested a review from ethanfrey as a code owner July 3, 2020 11:47
@codecov
Copy link

codecov bot commented Jul 3, 2020

Codecov Report

Merging #172 into master will decrease coverage by 47.98%.
The diff coverage is 62.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #172       +/-   ##
===========================================
- Coverage   67.90%   19.91%   -47.99%     
===========================================
  Files          23       25        +2     
  Lines        2053     6428     +4375     
===========================================
- Hits         1394     1280      -114     
- Misses        563     5079     +4516     
+ Partials       96       69       -27     
Impacted Files Coverage Δ
app/genesis.go 0.00% <0.00%> (ø)
x/wasm/internal/types/msg.go 40.77% <ø> (ø)
x/wasm/internal/types/query.pb.go 0.72% <ø> (ø)
x/wasm/internal/types/types.go 31.81% <0.00%> (-0.59%) ⬇️
x/wasm/internal/types/types.pb.go 0.55% <ø> (ø)
x/wasm/internal/keeper/querier.go 24.00% <13.17%> (-12.14%) ⬇️
x/wasm/module.go 17.02% <18.18%> (-0.76%) ⬇️
app/export.go 7.59% <21.42%> (+0.27%) ⬆️
x/wasm/internal/types/codec.go 52.38% <23.07%> (-47.62%) ⬇️
x/wasm/internal/keeper/query_plugins.go 57.71% <66.66%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f62e8a...6b5133e. Read the comment docs.

@alpe alpe mentioned this pull request Jul 3, 2020
3 tasks
@alpe alpe changed the base branch from 0.9.1_to_cosmos-sdk-0.39 to cosmos-sdk-0.39 July 3, 2020 12:21
@ethanfrey ethanfrey mentioned this pull request Jul 6, 2020
9 tasks
@ethanfrey ethanfrey changed the base branch from cosmos-sdk-0.39 to master July 15, 2020 12:37
@ethanfrey ethanfrey marked this pull request as draft July 15, 2020 12:37
@alpe alpe changed the title 0.9.1 to cosmos sdk 0.39 master Cosmos stargate tracking branch Jul 15, 2020
@alpe
Copy link
Contributor Author

alpe commented Aug 18, 2020

Closing this in favour of #252

@alpe alpe closed this Aug 18, 2020
@alpe alpe deleted the 0.9.1_to_cosmos-sdk-0.39-master branch August 27, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants