Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmos stargate tracking branch #172 #252

Closed
wants to merge 19 commits into from

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Aug 18, 2020

This is a tracking branch for the stargate upgrade.

  • CosmWasm 0.10.0
  • Cosmos SDK: ce9c2b2 (to be updated again, and again)

It also contains the IBC integration spec but the actual work to do so is in another branch

Known problems:

  • wasmcli tx send fails with cannot protobuf JSON encode unsupported type: *tx.builder, exiting... bug

Fixed

  • sdk contains fix for cli q account

This builds on work from many prior branches, which were discarded in the process of rebasing and merging;

@ethanfrey ethanfrey mentioned this pull request Aug 18, 2020
1 task
@ethanfrey
Copy link
Member

ethanfrey commented Aug 18, 2020

TODO:

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #252 into master will decrease coverage by 55.67%.
The diff coverage is 16.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #252       +/-   ##
===========================================
- Coverage   73.36%   17.68%   -55.68%     
===========================================
  Files          27       32        +5     
  Lines        2654    10593     +7939     
===========================================
- Hits         1947     1873       -74     
- Misses        594     8636     +8042     
+ Partials      113       84       -29     
Impacted Files Coverage Δ
x/wasm/internal/types/msg.go 52.67% <ø> (ø)
x/wasm/internal/types/proposal.pb.go 0.52% <ø> (ø)
x/wasm/internal/types/query.pb.go 0.66% <ø> (ø)
x/wasm/internal/types/test_fixtures.go 93.46% <ø> (-0.41%) ⬇️
x/wasm/internal/types/types.go 23.27% <ø> (-0.41%) ⬇️
x/wasm/internal/types/types.pb.go 0.75% <ø> (ø)
x/wasm/module.go 16.32% <ø> (-0.70%) ⬇️
x/wasm/internal/types/msg.pb.go 0.58% <0.58%> (ø)
x/wasm/internal/types/genesis.pb.go 0.82% <0.82%> (ø)
x/wasm/internal/types/codec.go 47.05% <18.18%> (-52.95%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a1dba...81b8138. Read the comment docs.

@alpe alpe force-pushed the 0.10_to_cosmos-stargate_ce9c2b2 branch from 0a6ccc2 to fa61594 Compare August 18, 2020 11:58
@ethanfrey
Copy link
Member

wasmcli tx send fails with `cannot protobuf JSON encode unsupported type: *tx.builder, exiting...`

🤦 and how is anyone supposed to integrate with this when the basic commands (query account, send tx) break daily

@alpe alpe force-pushed the 0.10_to_cosmos-stargate_ce9c2b2 branch from fa61594 to 5b3040a Compare August 18, 2020 13:39
@alpe alpe mentioned this pull request Aug 18, 2020
6 tasks
@alpe alpe changed the title 0.10 to Stargate ce9c2b2 Cosmos stargate tracking branch #172 Aug 18, 2020
@alpe alpe added the stargate label Aug 18, 2020
@ethanfrey ethanfrey mentioned this pull request Aug 19, 2020
4 tasks
@alpe alpe added this to the v1.0.0 milestone Oct 14, 2020
@alpe alpe mentioned this pull request Oct 27, 2020
@ethanfrey
Copy link
Member

Replaced by #293

@ethanfrey ethanfrey closed this Oct 29, 2020
@alpe alpe deleted the 0.10_to_cosmos-stargate_ce9c2b2 branch January 21, 2021 13:23
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
zemyblue pushed a commit to Finschia/wasmd that referenced this pull request Jan 2, 2023
…ster

* remotes/gaia/master: (38 commits)
  Merge PR CosmWasm#259: Bump SDK master commit
  Exec go mod tidy (CosmWasm#267)
  Merge PR CosmWasm#265: add version v2.0.5 to CHANGELOG
  Fix broken link in delegator guide (CosmWasm#262)
  docs: removed redundant readme.md (CosmWasm#261)
  Merge PR CosmWasm#258: Bump github.com/spf13/viper from 1.6.1 to 1.6.2
  Merge PR CosmWasm#250: Docs-update
  Merge PR CosmWasm#256: Bump github.com/pkg/errors from 0.9.0 to 0.9.1
  Merge PR CosmWasm#255: Bump github.com/pkg/errors from 0.8.1 to 0.9.0
  Merge PR CosmWasm#253: Bump SDK master commit
  Merge PR CosmWasm#252: v2.0.4 Changelog
  Merge PR CosmWasm#249: docker image build and upload for release tags
  Merge PR CosmWasm#247: Update SDK Commit & Update CLI Doc
  Merge PR CosmWasm#246: Update Archive page with explorers
  Merge PR CosmWasm#245: archives
  Bump SDK commit to the latest master (CosmWasm#239)
  Merge PR CosmWasm#215: Update simulation tests
  Update join-mainnet.md (CosmWasm#229)
  Incorporate SDK's latest changes (CosmWasm#227)
  Merge PR CosmWasm#221: Hide unnecessarily exported function to better coverage report
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants