Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove http request in validatebasic #48

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Conversation

sunnya97
Copy link
Contributor

closes #46

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@sunnya97 sunnya97 requested a review from ethanfrey as a code owner January 23, 2020 21:19
@sunnya97 sunnya97 changed the title remove http request remove http request in validatebasic Jan 23, 2020
@codecov-io
Copy link

Codecov Report

Merging #48 into master will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   61.46%   61.64%   +0.18%     
==========================================
  Files          15       15              
  Lines        1095     1095              
==========================================
+ Hits          673      675       +2     
+ Misses        356      354       -2     
  Partials       66       66
Impacted Files Coverage Δ
lcd_test/helpers.go 76.25% <0%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 877c24d...348a123. Read the comment docs.

Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper cleanup. Thank you.

@ethanfrey ethanfrey merged commit 7c9b480 into CosmWasm:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidateBasic should not be making http requests
3 participants