Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidateBasic should not be making http requests #46

Closed
sunnya97 opened this issue Jan 23, 2020 · 1 comment · Fixed by #48
Closed

ValidateBasic should not be making http requests #46

sunnya97 opened this issue Jan 23, 2020 · 1 comment · Fixed by #48

Comments

@sunnya97
Copy link
Member

sunnya97 commented Jan 23, 2020 •
edited
Loading

https://github.com/cosmwasm/wasmd/blob/master/x/wasm/internal/types/msg.go#L55

http requests are non-deterministic, and thus they cannot be called during validatebasic, which is part of delivertx
@sunnya97 sunnya97 mentioned this issue Jan 23, 2020
Merged
5 tasks
@ethanfrey
Copy link
Member

Very true. Thanks for catching this

zemyblue referenced this issue in Finschia/wasmd Jan 2, 2023
@alexanderbez
Merge PR #46: Upgrade to latest SDK version (73700df8c)
7d68770
loloicci pushed a commit to loloicci/wasmd that referenced this issue Jun 14, 2023
@tkxkd0159
feat: add admin-related events (CosmWasm#46)
bffff77 
* add admin-related events in docs
* fix ClearAdmin event
* cherry-pick upstream admin-related events update
loloicci added a commit to loloicci/wasmd that referenced this issue Aug 19, 2024
@loloicci @zemyblue
@jaeseung-bae @da1suk8 @tkxkd0159
build: merge main and update to use wasmvm@v1.1.1-0.11.2-dynamiclink2 (…
2e0fe8b 
…CosmWasm#53)

* build: replace line repositories with finschia repositories (CosmWasm#30)

* build: replace line repositories with finschia repositories

* Update x/wasmplus/README.md

Co-authored-by: zemyblue <zemyblue@gmail.com>

* Update x/wasm/ibc_reflect_test.go

Co-authored-by: zemyblue <zemyblue@gmail.com>

* Update .github/dependabot.yml

Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>

* Update CHANGELOG.md

Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>

* docs: replace a comment contains line with finschia one

* build: replace line in Dockerfile with finschia

* docs: replace line in README.md with Finschia

* docs: update CHANGELOG

---------

Co-authored-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>

* chore: update changelog for release v0.1.3 (CosmWasm#31)

* fix: stop wrap twice the response of handling non-plus wasm message in plus handler (CosmWasm#35)

* fix: stop wrap twice non-plus wasm hander's response

fix Finschia#33

* test: add tests handling non-plus wasm messages

* docs: add this PR to CHANGELOG.md

* fix: reflect golangci-lint

* fix: simplify how to handle the message in wasmplus

* chore: update notice (CosmWasm#44)

* chore: update notice

* chore: update changelog

* fix: delete unnecessary test (CosmWasm#43)

* fix: delete unnecessary test

* docs: add CHANGELOG

* feat: add admin-related events (CosmWasm#46)

* add admin-related events in docs
* fix ClearAdmin event
* cherry-pick upstream admin-related events update

* chore: update changelog for release v0.1.4 (CosmWasm#49)

* build: update depending wasmvm to v1.1.1-0.11.2-dynamiclink2 and update tests

---------

Co-authored-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
Co-authored-by: Daisuke Iuchi <42408108+da1suk8@users.noreply.github.com>
Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove http request in validatebasic sikkatech/wasmd
2 participants
@sunnya97 @ethanfrey