Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibc-go v3.2.0 #937

Merged
merged 15 commits into from
Sep 7, 2022
Merged

ibc-go v3.2.0 #937

merged 15 commits into from
Sep 7, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 10, 2022

OK I think this one does it :)

  • upgrades ibc-go to v3.2.x

@faddat faddat requested a review from alpe as a code owner August 10, 2022 03:37
@faddat
Copy link
Contributor Author

faddat commented Aug 10, 2022

thanks to @joeabbey for the upstream patch to ibc-go that made this work.

@faddat
Copy link
Contributor Author

faddat commented Aug 12, 2022

this is reaady to go

This was referenced Aug 13, 2022
@faddat
Copy link
Contributor Author

faddat commented Aug 15, 2022

Hey, as @sacha1337 points out, ibc-go 4.0 is released and compatible with the 45.* series sdk, so I am going to fork this branch, and make a second pr for that.

@faddat faddat changed the title 457 457+ibc-go v3.2.0 Aug 15, 2022
@alpe alpe mentioned this pull request Aug 25, 2022
@alpe
Copy link
Contributor

alpe commented Aug 25, 2022

Thanks a lot for your work and this PR! You have been very active to upgrade the dependencies. Please split SDK and IBC upgrades into separate PRs to have a better track of work for people watching this repo and to build the changelog. 🙏
I will branch from this PR and take care of this to move faster

@faddat
Copy link
Contributor Author

faddat commented Aug 25, 2022

sure, FYI, the SDK and ibc depencencies in this case, were inter-dependent because of the changes in 45.7 :)

(specifically, bumping ibc iirc, though maybe it was both?)

@faddat faddat changed the title 457+ibc-go v3.2.0 ibc-go v3.2.0 Aug 25, 2022
@alpe
Copy link
Contributor

alpe commented Aug 25, 2022

Thanks for rebasing the branch!
I have added a "blocked" tag to give everybody some days to discuss this upgrade.
It is a fresh release and I don't know if it is tested on mainnets well enough. I quickly browsed some other chain releases but could not fine any using v3.2 already.

@faddat faddat mentioned this pull request Aug 25, 2022
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #937 (f4de011) into main (49d571e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   59.34%   59.31%   -0.04%     
==========================================
  Files          51       51              
  Lines        6221     6221              
==========================================
- Hits         3692     3690       -2     
- Misses       2264     2265       +1     
- Partials      265      266       +1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 88.33% <0.00%> (-0.34%) ⬇️

@alpe alpe removed the blocked label Sep 7, 2022
@alpe alpe merged commit 355ee68 into CosmWasm:main Sep 7, 2022
@alpe
Copy link
Contributor

alpe commented Sep 7, 2022

Thanks for your help!

@alpe alpe mentioned this pull request Sep 8, 2022
@faddat faddat mentioned this pull request Oct 2, 2022
Magicloud pushed a commit to fpco/wasmd that referenced this pull request Jan 13, 2023
* 457

* upgrade ci

* go get -> go install

* change denom to new format

* Update config.yml

* Revert "change denom to new format"

This reverts commit e637cf5.

* bump ibc-go to v3.2.x

* Update config.yml

* ibc-go v3.2.0

* Update CHANGELOG.md

* Update CHANGELOG.md

* sdk v0.45.8
conorpp pushed a commit to wormhole-foundation/wasmd that referenced this pull request Feb 1, 2023
* 457

* upgrade ci

* go get -> go install

* change denom to new format

* Update config.yml

* Revert "change denom to new format"

This reverts commit e637cf5.

* bump ibc-go to v3.2.x

* Update config.yml

* ibc-go v3.2.0

* Update CHANGELOG.md

* Update CHANGELOG.md

* sdk v0.45.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants