Skip to content

Commit

Permalink
GH-596 Render int, float, and bool with user-friendly names
Browse files Browse the repository at this point in the history
  • Loading branch information
Naros committed Jul 27, 2024
1 parent d42f8c8 commit 01d9c03
Showing 1 changed file with 21 additions and 3 deletions.
24 changes: 21 additions & 3 deletions src/editor/select_type_dialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -102,17 +102,35 @@ Vector<Ref<OrchestratorEditorSearchDialog::SearchItem>> OrchestratorSelectTypeSe
// Basic Types
for (int i = 0; i < Variant::VARIANT_MAX; i++)
{
const String variant_type = Variant::get_type_name(VariantUtils::to_type(i));
const Variant::Type type = VariantUtils::to_type(i);
const String variant_type = Variant::get_type_name(type);
_variant_type_names.push_back(variant_type);

if (_exclusions.has(variant_type))
continue;

String friendly_name;
switch (type)
{
case Variant::INT:
friendly_name = "Integer";
break;
case Variant::BOOL:
friendly_name = "Boolean";
break;
case Variant::FLOAT:
friendly_name = "Float";
break;
default:
friendly_name = variant_type;
break;
};

Ref<SearchItem> item(memnew(SearchItem));
item->path = vformat("Types/%s", i == 0 ? "Any" : variant_type);
item->name = vformat("type:%s", variant_type);
item->text = i == 0 ? "Any" : variant_type;
item->icon = SceneUtils::get_editor_icon(i == 0 ? "Variant" : item->text);
item->text = i == 0 ? "Any" : friendly_name;
item->icon = SceneUtils::get_editor_icon(i == 0 ? "Variant" : variant_type);
item->selectable = true;
item->parent = root;
items.push_back(item);
Expand Down

0 comments on commit 01d9c03

Please sign in to comment.