Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variable type names should be shown consistently #596

Closed
Naros opened this issue Jul 27, 2024 · 0 comments · Fixed by #598
Closed

Variable type names should be shown consistently #596

Naros opened this issue Jul 27, 2024 · 0 comments · Fixed by #598
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Milestone
2.1

Comments

@Naros
Copy link
Member

Naros commented Jul 27, 2024

Describe the bug

In the variable type selection dialog, the int and bool types use their Variant::get_type_name naming, which is inconsistent with the other types that are shown. Additionally, the float type is not using capitalize-case like the other, too.

Notes:
Users should be able to type int and the Integer type should match.
Users should be able to type bool and the Boolean type should match.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

2.1.rc2

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 27, 2024
@Naros Naros added this to the 2.1 milestone Jul 27, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 27, 2024
@Naros
CraterCrashGH-596 Render int, float, and bool with user-friendl…
85c1589 
…y names
@Naros Naros mentioned this issue Jul 27, 2024
Merged
Naros added a commit that referenced this issue Jul 27, 2024
@Naros
GH-596 Render int, float, and bool with user-friendly names
5c4babd
Naros added a commit that referenced this issue Jul 27, 2024
@Naros
GH-596 Render int, float, and bool with user-friendly names
01d9c03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

GH-596 Render int, float, and bool with user-friendly names Naros/godot-orchestrator
1 participant
@Naros