GH-190 Do not cache instantiated scene node

CraterCrash · Mar 23, 2024 · 5e36291 · 5e36291
1 parent fdec82f
commit 5e36291
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/script/nodes/scene/instantiate_scene.cpp b/src/script/nodes/scene/instantiate_scene.cpp
@@ -25,7 +25,6 @@ class OScriptNodeInstantiateSceneInstance : public OScriptNodeInstance
     DECLARE_SCRIPT_NODE_INSTANCE(OScriptNodeInstantiateScene);
     String _scene_name;
     Ref<PackedScene> _scene;
-    Node* _scene_node;
 
 public:
     int step(OScriptNodeExecutionContext& p_context) override
@@ -38,10 +37,10 @@ class OScriptNodeInstantiateSceneInstance : public OScriptNodeInstance
                 p_context.set_error(GDEXTENSION_CALL_ERROR_INVALID_METHOD, "Failed to load scene");
                 return -1;
             }
-            _scene_node = _scene->instantiate();
         }
 
-        p_context.set_output(0, _scene_node);
+        Node* scene_node = _scene->instantiate();
+        p_context.set_output(0, scene_node);
         return 0;
     }
 };