Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signal add callback does not decode arguments correctly #492

Closed
Naros opened this issue Jul 9, 2024 · 0 comments · Fixed by #493
Closed

Signal add callback does not decode arguments correctly #492

Naros opened this issue Jul 9, 2024 · 0 comments · Fixed by #493
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.

Comments

@Naros
Copy link
Member

Naros commented Jul 9, 2024

Describe the bug

When adding a new signal handler, arguments are not decoded properly and are always listed as Variant types, when they should actually be potentially typed to specific native classes such as Area3D or Node2D.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Godot full version

No response

Orchestrator version

No response

Additional information

No response
@Naros Naros added kind/bug A bug or regression in expected behavior. bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 labels Jul 9, 2024
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 9, 2024
@Naros
CraterCrashGH-492 Correctly resolve signal argument types
7d3970f
Naros added a commit to Naros/godot-orchestrator that referenced this issue Jul 9, 2024
@Naros
CraterCrashGH-492 Allow disconnect slot from component panels
445e3a7
@Naros Naros mentioned this issue Jul 9, 2024
Merged
@Naros Naros closed this as completed in #493 Jul 9, 2024
Naros added a commit that referenced this issue Jul 9, 2024
@Naros
GH-492 Correctly resolve signal argument types
d185cda
Naros added a commit that referenced this issue Jul 9, 2024
@Naros
GH-492 Allow disconnect slot from component panels
5b99f04
Naros added a commit that referenced this issue Jul 9, 2024
@Naros
GH-492 Correctly resolve signal argument types
80fda2d
Naros added a commit that referenced this issue Jul 9, 2024
@Naros
GH-492 Allow disconnect slot from component panels
4d7cc01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/confirmed Bug/regression has been confirmed. cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 kind/bug A bug or regression in expected behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-492 Correctly resolve signal argument types Naros/godot-orchestrator
1 participant
@Naros