GH-492 Correctly resolve signal argument types #493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492
This change aims to improve the creation of signal slot function handlers by ensuring that argument types are resolved as appropriate class types rather than always treating them as explicit
Variant
or basic types. In addition, this fix includes a few enhancements.Add signals to not yet opened Orchestrations
In prior releases, the
Orchestration
must be opened in the Orchestrator tab before a signal slot function can be added to the script. If this was not the case, the signal would get registered in the scene but no function would be created in the script to handle the signal when fired.The callback handler method has been relocated to the main editor panel widget, which is always active in the Editor. This means that if you create a signal slot handler function and pick a node that has an Orchestration on it, the callback will be handled by Orchestrator even if the script is not yet opened. If the script isn't opened, it will be opened. If the Orchestrator tab is not the current main focus in the Editor, it will be made active as well. This should help with overall workflow.
Disconnecting slot functions
A slot function, one which has a green icon to the right of its name, can now be disconnected from the signal by simply right clicking the Graph Function or User-defined Function in the component view and selecting
Disconnect
.