Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-492 Correctly resolve signal argument types #493

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

Naros
Copy link
Member

@Naros Naros commented Jul 9, 2024

Fixes #492

This change aims to improve the creation of signal slot function handlers by ensuring that argument types are resolved as appropriate class types rather than always treating them as explicit Variant or basic types. In addition, this fix includes a few enhancements.

Add signals to not yet opened Orchestrations

In prior releases, the Orchestration must be opened in the Orchestrator tab before a signal slot function can be added to the script. If this was not the case, the signal would get registered in the scene but no function would be created in the script to handle the signal when fired.

The callback handler method has been relocated to the main editor panel widget, which is always active in the Editor. This means that if you create a signal slot handler function and pick a node that has an Orchestration on it, the callback will be handled by Orchestrator even if the script is not yet opened. If the script isn't opened, it will be opened. If the Orchestrator tab is not the current main focus in the Editor, it will be made active as well. This should help with overall workflow.

Disconnecting slot functions

A slot function, one which has a green icon to the right of its name, can now be disconnected from the signal by simply right clicking the Graph Function or User-defined Function in the component view and selecting Disconnect.

@Naros Naros added the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jul 9, 2024
@Naros Naros added this to the 2.1 milestone Jul 9, 2024
@Naros Naros merged commit 5b99f04 into CraterCrash:main Jul 9, 2024
8 checks passed
@Naros Naros deleted the GH-492 branch July 9, 2024 03:45
@Naros Naros removed the cherrypick:2.0 Requires cherry-pick to Orchestrator 2.0 label Jul 9, 2024
@Naros
Copy link
Member Author

Naros commented Jul 9, 2024

Applied to main (=2.1) and branch 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal add callback does not decode arguments correctly
1 participant