-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【LocalNouns】ミント条件の整備 #157
Merged
Merged
【LocalNouns】ミント条件の整備 #157
Changes from 10 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4086ad1
add comment
EibaKatsu db0f5a7
mintSelectedPrefectureに数量指定追加
EibaKatsu cf464e1
mintSelectedPrefectureBatchの削除
EibaKatsu c528f8a
mintSelectedPrefectureBatch削除
EibaKatsu 5206f5a
tokenGate追加
EibaKatsu cf9776d
whitelistをpublicに変更
EibaKatsu ec80ef1
tokenGateによるチェック追加
EibaKatsu aa5acfa
tokenGate追加
EibaKatsu 0ece521
*_localhost.ts追加
EibaKatsu 57c53b2
Send ETH チェック追加
EibaKatsu 2b8df41
_nextTokenIdは_safeMintで更新されるので indexを追加
EibaKatsu 0416893
都道府県ごとのミント数mintNumberPerPrefectureを追加
EibaKatsu 7e69903
コメント修正
EibaKatsu 55e49ad
都道府県番号のチェック追加
EibaKatsu 1f91eed
継承元のmintPrice, mintLimitは使用しない
EibaKatsu 2331227
コメント追加
EibaKatsu bddb21b
ミント数上限のチェック
EibaKatsu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
memo
minterが指定する県をnのmintする。
LocalNounsProvider.solがよばれる。
mint(uint256 prefectureId, uint256 _assetId)
1,2桁目:都道府県番号、3桁目以降:バージョン番号??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EibaKatsu
150, 73など、2桁が都道府県番号じゃない場合にはどうなりますか?
どこかでvalidationいれたほうがよさそうですね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「バージョン番号??」は使ってないように見えますが必要ですか?
必要でないのであれば0 ~ 47指定にして0ならランダムのほうが良いですね。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LocalNounsMinter.solのmintSelectedPrefectureから呼び出しいるのだと思いますが、
ここはpriceがあるので一般ユーザが使うと理解しています。
であれば
require(msg.sender == minter, 'Sender is not the minter');
があるので、呼べないとなりませんか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
初回セールではバージョンを使用しません。
今後HEADパーツが追加された場合に、追加したパーツだけのセールをしたいのでバージョンを設けています。
filenameの先頭がバージョン+都道府県番号で以下のイメージになります。
バージョンなし(初回)
バージョンあり(パーツ追加後)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
表現がおかしいですね、、
下2桁:都道府県番号、下3桁より上位:バージョン番号です。
コメント修正しておきます。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
追加しました。55e49ad
追記:
存在しないバージョン+都道府県番号だとミント時にエラーになるので、厳密な存在チェックは割愛します。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mintPrice, mintLimit のミント条件は、Minterコントラクト側で制御します。
この変数を使用しないことをコメントしておきました。
1f91eed
2331227