Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Biome size #63

Open
69b69t opened this issue Sep 8, 2021 · 5 comments
Open

[Feature Request] Biome size #63

69b69t opened this issue Sep 8, 2021 · 5 comments

Comments

@69b69t
Copy link

69b69t commented Sep 8, 2021

Title speaks for itself, it would be nice to have a way to search for biomes with a certain size

@Cubitect
Copy link
Owner

Cubitect commented Mar 2, 2022

You essentially already can. For instance if you exclude all other biomes from a given area, you'll match biomes for that size.

@Delvin4519
Copy link

This issue is similar to my 1:256 count biome instances request, since the existing exclude function for normal 1:256 sized biomes is a bit more cumbersome than the existing "count tiles" feature for 1:1024 climate zones. You can't count up number of biome tiles like you can for climate zones, which would allow one to get more customizable biome sizes.

@Cubitect
Copy link
Owner

Cubitect commented Oct 1, 2022

In v2.5 there is now a filter that can locate a given biome and offers a minimum size requirement as well as a border tolerance that controls how much biome clusters are united (biomes tend to have a fuzzy edge).

@Delvin4519
Copy link

Delvin4519 commented Oct 1, 2022

The new filter only seems to be available at a 1:4 scale, I feel like it would still be much easier to search for biome sizes based off counting the number of tiles the 1:256 scale, and it would be a lot faster, and much easier to understand, use, and set up, at 1:256 scale (just count the number of tiles like climate zones).

Border tolerance isn't as straighforward to understand. The fuzzy edge of biomes is when biomes are zoomed in higher from 1:256 scale. (Note: all of this is based off the Java 1.7/1.12/1.17).

@Cubitect
Copy link
Owner

Cubitect commented Oct 1, 2022

The in-game biome scale is 1:4 for all actual uses. For 1.18+ there are no layers with higher scales and the scales are faked by cubiomes by just sampling every other coordinate, which is okay for displaying on a map, but is problematic if you try to do anything else with it. This also does not solve the fuzzy edge connectivity problem, which applies mostly to 1.18+, and only complicating things further.

Your suggestion for a 1:256 scaled biome counter is only really applicable for the layered generation of 1.17-, but I also see a couple of implementation problems there, if done like the temperature categories. The first is UI clutter, and the second is a significantly larger memory size of the conditions to store a counter for each biome which I would very much like to avoid. I guess both might be avoidable if the filter is limited to a single biome, like with the new biome center locator.

Cubitect added a commit that referenced this issue Nov 13, 2022
* added UI event buffering to the anaylsis results, making it much more performant with many seeds (#122)
* added custom separator option for csv export (#122)
* added DejaVuSans monospace font for a more consistent look (#107)
* added filter for biome center locations with scale 1:256 for versions up to 1.17 (#63)
* changed biome statistics UI to display seeds as rows (#122)
* changed matching seed list and some anaylsis results to be tristate sortable
* changed zoom limits for the goto dialog, allowing a larger manual zoom range (#162)
* changed abandoned village and end ship modifiers to be a tristate with exclude option (#168)
* fixed incorrect progress display for anaylses (#165)
* fixed stronghold filter so it doesn't skip the last inner ring stronghold (#171)
* fixed slightly inaccurate biome check location for some villages and bastions (#168)
* + few more minor fixes and tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants