-
-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: publish OpenTelemetry support to NuGet listed latest version. #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guitarrapc
changed the title
feat: publish OpenTelemetry support to NuGet 1.0.0-rc3
feat: publish OpenTelemetry support to NuGet 1.0.0-rc1.1
Apr 6, 2021
guitarrapc
force-pushed
the
feat/opentelemetry_100rc11
branch
2 times, most recently
from
June 1, 2021 01:47
55c3218
to
5b4168b
Compare
guitarrapc
force-pushed
the
feat/opentelemetry_100rc11
branch
from
June 1, 2021 01:55
5b4168b
to
156adfe
Compare
guitarrapc
force-pushed
the
feat/opentelemetry_100rc11
branch
from
June 2, 2021 17:11
4a1f6e2
to
5fee3fd
Compare
guitarrapc
changed the title
feat: publish OpenTelemetry support to NuGet 1.0.0-rc1.1
feat: publish OpenTelemetry support to NuGet listed latest version.
Jun 2, 2021
Linux has Tracer not sending issue. |
|
All know issues are solved by Splitting Instrumentation. |
mayuki
approved these changes
Jun 11, 2021
AntonC9018
pushed a commit
to AntonC9018/MagicOnion
that referenced
this pull request
Sep 13, 2022
feat: publish OpenTelemetry support to NuGet listed latest version.
AntonC9018
pushed a commit
to AntonC9018/MagicOnion
that referenced
this pull request
Sep 13, 2022
feat: publish OpenTelemetry support to NuGet listed latest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #421
TL;DR;
IMagicOnionServerBuilder.AddOpenTelemetry()
to ListenerIMagicOnionServerBuilder.AddOpenTelemetry()
and InstrumentationTracerProviderBuilder.AddMagicOnionInstrumentation()
. This offer Standard OpenTelemetry usage and simpler MagicOnion Integration. (see sample code)beta2-1.1.0
which representOpenTelemery 1.1.0-beta2
.Nov/2021)
Summary
BreakingChange: Drop Metrics support
OpenTelemetry 1.0.1 is released for Tracer packages, however Metrics are dropped until .NET 6 release.
Follow to OpenTelemetry package, MagicOnion drop Metrics support.
BreakingChange: Split Listener and Instrumentations
Previously MagicOnion.OpenTelemetry integrate "Listen Activity" and "Enable Instrumentation" in single
IMagicOnionServerBuilder.AddOpenTelemetry()
. However this prevent user from standard OpenTelemetry usage.Now it's separate to activity listener and enable instrumentation.
IMagicOnionServerBuilder.AddOpenTelemetry()
listen Activity and DI MagicOnionTelemetryOptions.TracerProviderBuilder.AddMagicOnionInstrumentation()
enable MagicOnion Instrumentations.before
after
Enahance: Support OpenTelemetry Context Propagation
Now OpenTelemetry Context will propagate from server to server. This is done via gRPC Request Header.
This enable external MagicOnion Service Span integrate to single TraceId and under caller Spanid.
Example shows external MagicOnion
MicroServer
is called fromChatApp.Server
'sChatApp.Server.S2S
operation.REF