Remove metrics from 1.0.0 release #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1743 +/- ##
==========================================
- Coverage 83.28% 82.89% -0.39%
==========================================
Files 250 193 -57
Lines 6874 6005 -869
==========================================
- Hits 5725 4978 -747
+ Misses 1149 1027 -122
|
reyang
approved these changes
Jan 29, 2021
cijothomas
added a commit
that referenced
this pull request
Jan 29, 2021
This reverts commit 29995ec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics will release separately as a pre-release (like 1.1.0-alpha1), from a separate branch.
Immediate next steps after this PR merged:
create metrics branch off master, and revert this PR in that branch.
git tag metrics branch as 1.1.0-alpha1
modify MyGet daily publish GH action to run for both master,metrics branch. (this will publish 1.0.0-RC1 series packages from master, 1.1.0-alpha1 series from metrics branch and has metrics code)
reroute the in-flight metric PRs to metrics branch.
See #1501 for overall metrics plan.