Skip to content

Merge remote-tracking branch 'origin/master' #7

Merge remote-tracking branch 'origin/master'

Merge remote-tracking branch 'origin/master' #7

Triggered via push November 17, 2023 16:33
Status Success
Total duration 4m 36s
Artifacts

cli-build.yml

on: push
Fit to window
Zoom out
Zoom in

Annotations

8 warnings
unnecessarily eager cloning of iterator items: theseus_cli/src/subcommands/profile.rs#L179
warning: unnecessarily eager cloning of iterator items --> theseus_cli/src/subcommands/profile.rs:179:17 | 179 | loaders.iter().cloned().find(filter).ok_or_else(|| { | ^^^^^^^^^^^^^^---------------------- | | | help: try: `.find(|&x| filter(x)).cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned = note: `#[warn(clippy::iter_overeager_cloned)]` on by default
the borrowed expression implements the required traits: theseus/src/launcher/mod.rs#L180
warning: the borrowed expression implements the required traits --> theseus/src/launcher/mod.rs:180:27 | 180 | &io::canonicalize(&profile.get_profile_full_path().await?)?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `profile.get_profile_full_path().await?` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
unnecessarily eager cloning of iterator items: theseus/src/api/profile/create.rs#L273
warning: unnecessarily eager cloning of iterator items --> theseus/src/api/profile/create.rs:273:26 | 273 | let loader_version = loaders | ___________________________^ 274 | | .iter() | | ________________- 275 | || .cloned() 276 | || .find(filter) | ||_____________________^ | |_____________________| | help: try: `.find(|&x| filter(x)).cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned = note: `#[warn(clippy::iter_overeager_cloned)]` on by default
function `refresh_credentials` is never used: theseus/src/launcher/auth.rs#L46
warning: function `refresh_credentials` is never used --> theseus/src/launcher/auth.rs:46:14 | 46 | pub async fn refresh_credentials( | ^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default
variable does not need to be mutable: theseus/src/api/auth.rs#L41
warning: variable does not need to be mutable --> theseus/src/api/auth.rs:41:9 | 41 | let mut users = state.users.write().await; | ----^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default
braces around Deserialize is unnecessary: theseus/src/api/hydra/complete.rs#L3
warning: braces around Deserialize is unnecessary --> theseus/src/api/hydra/complete.rs:3:1 | 3 | use serde::{Deserialize}; | ^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> theseus/src/lib.rs:7:9 | 7 | #![warn(unused_import_braces)] | ^^^^^^^^^^^^^^^^^^^^
unused import: `self`: theseus/src/api/auth.rs#L3
warning: unused import: `self` --> theseus/src/api/auth.rs:3:13 | 3 | hydra::{self, init::DeviceLoginSuccess}, | ^^^^ | = note: `#[warn(unused_imports)]` on by default
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/