Merge remote-tracking branch 'origin/master' #7
clippy
7 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 7 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.74.0 (79e9716c9 2023-11-13)
- cargo 1.74.0 (ecb9851af 2023-10-18)
- clippy 0.1.74 (79e9716 2023-11-13)
Annotations
Check warning on line 179 in theseus_cli/src/subcommands/profile.rs
github-actions / clippy
unnecessarily eager cloning of iterator items
warning: unnecessarily eager cloning of iterator items
--> theseus_cli/src/subcommands/profile.rs:179:17
|
179 | loaders.iter().cloned().find(filter).ok_or_else(|| {
| ^^^^^^^^^^^^^^----------------------
| |
| help: try: `.find(|&x| filter(x)).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned
= note: `#[warn(clippy::iter_overeager_cloned)]` on by default
Check warning on line 180 in theseus/src/launcher/mod.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> theseus/src/launcher/mod.rs:180:27
|
180 | &io::canonicalize(&profile.get_profile_full_path().await?)?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `profile.get_profile_full_path().await?`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Check warning on line 276 in theseus/src/api/profile/create.rs
github-actions / clippy
unnecessarily eager cloning of iterator items
warning: unnecessarily eager cloning of iterator items
--> theseus/src/api/profile/create.rs:273:26
|
273 | let loader_version = loaders
| ___________________________^
274 | | .iter()
| | ________________-
275 | || .cloned()
276 | || .find(filter)
| ||_____________________^
| |_____________________|
| help: try: `.find(|&x| filter(x)).cloned()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_overeager_cloned
= note: `#[warn(clippy::iter_overeager_cloned)]` on by default
Check warning on line 46 in theseus/src/launcher/auth.rs
github-actions / clippy
function `refresh_credentials` is never used
warning: function `refresh_credentials` is never used
--> theseus/src/launcher/auth.rs:46:14
|
46 | pub async fn refresh_credentials(
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 41 in theseus/src/api/auth.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> theseus/src/api/auth.rs:41:9
|
41 | let mut users = state.users.write().await;
| ----^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
Check warning on line 3 in theseus/src/api/hydra/complete.rs
github-actions / clippy
braces around Deserialize is unnecessary
warning: braces around Deserialize is unnecessary
--> theseus/src/api/hydra/complete.rs:3:1
|
3 | use serde::{Deserialize};
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
note: the lint level is defined here
--> theseus/src/lib.rs:7:9
|
7 | #![warn(unused_import_braces)]
| ^^^^^^^^^^^^^^^^^^^^
Check warning on line 3 in theseus/src/api/auth.rs
github-actions / clippy
unused import: `self`
warning: unused import: `self`
--> theseus/src/api/auth.rs:3:13
|
3 | hydra::{self, init::DeviceLoginSuccess},
| ^^^^
|
= note: `#[warn(unused_imports)]` on by default