Builds Failing From Missing Unittest file #5461
Labels
bug
Something isn't working
Comments
|
looking at it
…On Fri, Apr 12, 2024 at 17:29 acpaquette ***@***.***> wrote:
*ISIS version(s) affected*: dev
*Description*
From PR #5424 <#5424> there
was/is a missing unittest.cpp file that caused weird build errors and
failing tests on linux. @kledmundson <https://github.com/kledmundson> It
seems like this was not caught and I am unsure why.
*How to reproduce*
Try to build and run unittests on linux systems from a clean slate.
*Possible Solution*
Can the missing file be added @kledmundson
<https://github.com/kledmundson>
*Additional context*
—
Reply to this email directly, view it on GitHub
<#5461>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABUGSUWDUKNKZG6VIWF6G73Y5B37JAVCNFSM6AAAAABGE67PYOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DCMJUG4ZDKNA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Wondering if the problem is not the missing unit test but that I accidentally left in the file IrregularBodyCameraGroundMap.truth in the IrregularBodyCameraGroundMap directory? What do you think? I can regenerate the unit test or remove the truth data file. |
kledmundson
added a commit
to kledmundson/ISIS3
that referenced
this issue
Apr 13, 2024
…eviously removed the unit test but neglected to remove associated truth file. Addresses DOI-USGS#5461.
kledmundson
added a commit
to kledmundson/ISIS3
that referenced
this issue
Apr 13, 2024
…so in original Tagcams instrument import PR. Addresses DOI-USGS#5461.
12 tasks
kledmundson
added a commit
to kledmundson/ISIS3
that referenced
this issue
Apr 13, 2024
AustinSanders
pushed a commit
that referenced
this issue
Apr 14, 2024
|
Closed by #5462 |
acpaquette
pushed a commit
to acpaquette/ISIS3
that referenced
this issue
Apr 19, 2024
* Removed IrregularBodyCameraGroundMap.truth file. Had neglected to do so in original Tagcams instrument import PR. Addresses DOI-USGS#5461. * Changelog entry for removal of IrregularBodyCameraGroundMap truth file. Addresses DOI-USGS#5461.
acpaquette
added a commit
that referenced
this issue
Apr 19, 2024
* Disable HRSC from spice server (#5270) * Disable HRSC from spice server * added docs * Added test * added changelog * Update spiceinit URL (#5431) * Update spiceinit URL * added changelog * Removed capital E that caused an error (#5466) * Removed capital E that caused an error * Updated changelog * Updated references to isis_version.txt (#5464) * Updated references to isis_version.txt * Updated changelog * Removed IrregularBodyCameraGroundMap.truth file. (#5462) * Removed IrregularBodyCameraGroundMap.truth file. Had neglected to do so in original Tagcams instrument import PR. Addresses #5461. * Changelog entry for removal of IrregularBodyCameraGroundMap truth file. Addresses #5461. * Update HistogramTool to better support high dynamic range images (#5445) * Updated histogram to create bin size based on dynamic range of window instead of full image * Updated changelog * Changed 'version' filename to honor reserved keyword. (#5434) * Changed 'version' filename to honor cmake reserved keyword. Changed 'version' filename to isis_version.txt. 'version' is a reserved keyword in cmake. Additionally, the extension should prevent this file from being compiled as source, and eliminate the recompilation error. * Updated changelog * Reverted accidental change to version * Updated version file name * Fixed noproj bug where missing shapemodel-related keywords (RayTraceEngine, BulletParts, Tolerance) are dropped when the output label is created. (#5378) * Fixed noproj bug where missing shapemodel-related keywords (RayTraceEngine, BulletParts, Tolerance) are dropped when the output label is created. This resulted in the Bullet collision detection engine not being used. Addresses #5377. * Per review, moved changelog entry to the Unreleased section. Addresses #5377. * Fixed bug in noproj where some temporary files were not deleted after completion (#5403) * Fixed noproj bug where some temporary files were not cleaned up (deleted) after call to cam2cam. Also reworked how these temporary files are identified. Addresses #4813. * Added copyright statement at top of source and header files. Addresses #4813. * Fixed Underscore Env Var Expansion (#5402) * Fixed env var expansion to include underscores * Added test to cover change * Added changelog entry * Renamed tests * Fixes match cube default to NULL (#5429) * Updated rclone.conf to point to naif archived kernels (#5442) * naif source includes /pub/naif, _naifkernels point to archived locations if available * https for naif * naif kernel fix description in changelog * Fits Import fix (#5469) * Fixed FitsToJson subprocess error * Added changelog entry * Update Hayabusa2 translation (#5433) * Add spacecraft name trn * Update changelog * Added hyb2onc2isis test --------- Co-authored-by: Kelvin Rodriguez <krodriguez@usgs.gov> * Added Code.json entry * Update CHANGELOG.md * Update version in meta.yaml * Update version in CMakeLists.txt --------- Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Austin Sanders <arsanders@usgs.gov> Co-authored-by: kledmundson <6842706+kledmundson@users.noreply.github.com> Co-authored-by: Jacob Cain <115182890+jrcain-usgs@users.noreply.github.com> Co-authored-by: Christine Kim <125395064+chkim-usgs@users.noreply.github.com> Co-authored-by: Kelvin Rodriguez <krodriguez@usgs.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ISIS version(s) affected: dev
Description
From PR #5427 there was/is a missing unittest.cpp file that caused weird build errors and failing tests on linux. @kledmundson It seems like this was not caught and I am unsure why.
How to reproduce
Try to build and run unittests on linux systems from a clean slate.
Possible Solution
Can the missing file be added @kledmundson
Additional context
The text was updated successfully, but these errors were encountered: