Fixed Underscore Env Var Expansion #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
reviewed
Jan 10, 2024
|
I think this is good but I'll wait for Jenkins to come back |
|
@Kelvinrr Looks good, all test failures are also failing on dev |
Kelvinrr
approved these changes
Jan 19, 2024
acpaquette
added a commit
to acpaquette/ISIS3
that referenced
this pull request
Apr 19, 2024
* Fixed env var expansion to include underscores * Added test to cover change * Added changelog entry * Renamed tests
acpaquette
added a commit
that referenced
this pull request
Apr 19, 2024
* Disable HRSC from spice server (#5270) * Disable HRSC from spice server * added docs * Added test * added changelog * Update spiceinit URL (#5431) * Update spiceinit URL * added changelog * Removed capital E that caused an error (#5466) * Removed capital E that caused an error * Updated changelog * Updated references to isis_version.txt (#5464) * Updated references to isis_version.txt * Updated changelog * Removed IrregularBodyCameraGroundMap.truth file. (#5462) * Removed IrregularBodyCameraGroundMap.truth file. Had neglected to do so in original Tagcams instrument import PR. Addresses #5461. * Changelog entry for removal of IrregularBodyCameraGroundMap truth file. Addresses #5461. * Update HistogramTool to better support high dynamic range images (#5445) * Updated histogram to create bin size based on dynamic range of window instead of full image * Updated changelog * Changed 'version' filename to honor reserved keyword. (#5434) * Changed 'version' filename to honor cmake reserved keyword. Changed 'version' filename to isis_version.txt. 'version' is a reserved keyword in cmake. Additionally, the extension should prevent this file from being compiled as source, and eliminate the recompilation error. * Updated changelog * Reverted accidental change to version * Updated version file name * Fixed noproj bug where missing shapemodel-related keywords (RayTraceEngine, BulletParts, Tolerance) are dropped when the output label is created. (#5378) * Fixed noproj bug where missing shapemodel-related keywords (RayTraceEngine, BulletParts, Tolerance) are dropped when the output label is created. This resulted in the Bullet collision detection engine not being used. Addresses #5377. * Per review, moved changelog entry to the Unreleased section. Addresses #5377. * Fixed bug in noproj where some temporary files were not deleted after completion (#5403) * Fixed noproj bug where some temporary files were not cleaned up (deleted) after call to cam2cam. Also reworked how these temporary files are identified. Addresses #4813. * Added copyright statement at top of source and header files. Addresses #4813. * Fixed Underscore Env Var Expansion (#5402) * Fixed env var expansion to include underscores * Added test to cover change * Added changelog entry * Renamed tests * Fixes match cube default to NULL (#5429) * Updated rclone.conf to point to naif archived kernels (#5442) * naif source includes /pub/naif, _naifkernels point to archived locations if available * https for naif * naif kernel fix description in changelog * Fits Import fix (#5469) * Fixed FitsToJson subprocess error * Added changelog entry * Update Hayabusa2 translation (#5433) * Add spacecraft name trn * Update changelog * Added hyb2onc2isis test --------- Co-authored-by: Kelvin Rodriguez <krodriguez@usgs.gov> * Added Code.json entry * Update CHANGELOG.md * Update version in meta.yaml * Update version in CMakeLists.txt --------- Co-authored-by: Amy Stamile <74275278+amystamile-usgs@users.noreply.github.com> Co-authored-by: Austin Sanders <arsanders@usgs.gov> Co-authored-by: kledmundson <6842706+kledmundson@users.noreply.github.com> Co-authored-by: Jacob Cain <115182890+jrcain-usgs@users.noreply.github.com> Co-authored-by: Christine Kim <125395064+chkim-usgs@users.noreply.github.com> Co-authored-by: Kelvin Rodriguez <krodriguez@usgs.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ISIS was failing to expand
$CONDA_PREFIX, when I dug into it I found that the "_" was considered an ending token for environment variables. This PR fixes this.Related Issue
N/A
How Has This Been Validated?
Added test to cover change
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: