Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing changes to getsnalltrue #4020

Closed
wants to merge 13 commits into from

Conversation

AustinSanders
Copy link
Contributor

This PR is necessary for testing the changes to getsnalltrue, which passes locally on OSX, but fails on Jenkins.

Description

This PR will probably get a lot of changes back and forth, including commenting out lines of code. This PR is not intended for merge or review.

Related Issue

getsnalltrue fails

Motivation and Context

Test failure

How Has This Been Tested?

This is the test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation change (update to the documentation; no code change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read and agree to abide by the Code of Conduct
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added myself to the .zenodo.json document.
  • I have added any user impacting changes to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

@Kelvinrr
Copy link
Collaborator

Kelvinrr commented Sep 16, 2020

I think you can set this to a draft if it's not ready for review and the Jenkins jobs will still trigger.

@AustinSanders AustinSanders marked this pull request as draft September 16, 2020 19:58
@AustinSanders AustinSanders marked this pull request as ready for review September 16, 2020 23:08
@AustinSanders AustinSanders marked this pull request as draft September 16, 2020 23:09
@AustinSanders AustinSanders marked this pull request as ready for review September 16, 2020 23:14
@AustinSanders AustinSanders marked this pull request as draft September 16, 2020 23:24
@AustinSanders AustinSanders marked this pull request as ready for review September 17, 2020 05:21
@AustinSanders AustinSanders marked this pull request as draft September 17, 2020 05:22
@AustinSanders
Copy link
Contributor Author

This PR is messy, and it includes a lot of debugging commits. Closing in favor of #4022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants