Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing changes to getsnalltrue #4020

Closed
wants to merge 13 commits into from
Closed

Testing changes to getsnalltrue #4020

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
3e79dc7
Added support for all MCP gain settings.
AustinSanders Nov 5, 2019
e5f67c6
Revised comments to better reflect updated logic
AustinSanders Nov 6, 2019
063ddf8
Added history comment.
AustinSanders Nov 6, 2019
eaf8851
Added additional description and link to Robinson paper.
AustinSanders Nov 8, 2019
19f3ea8
Added preferences variable to shapemodel path.
AustinSanders Nov 16, 2019
42e9e15
Merge branch 'dev' of https://github.com/USGS-Astrogeology/ISIS3 into…
AustinSanders Nov 16, 2019
bf01e31
Merge branch 'dev' of https://github.com/USGS-Astrogeology/ISIS3 into…
Mar 20, 2020
f4c0022
Merge branch 'dev' of https://github.com/USGS-Astrogeology/ISIS3 into…
Sep 15, 2020
c512f66
Test if l37 is causing test failure.
Sep 16, 2020
167b5b5
.
Sep 16, 2020
c4f6e13
..
Sep 17, 2020
d17213b
Comment out UI instantiation
Sep 17, 2020
42bf6a1
Instantiated non-static app_xml
Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions isis/tests/FunctionalTestsGetsn.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,19 @@ static QString APP_XML = FileName("$ISISROOT/bin/xml/getsn.xml").expanded();

// check for all correct outputs
TEST_F(DefaultCube, FunctionalTestGetsnAllTrue) {
QString d_APP_XML = FileName("$ISISROOT/bin/xml/getsn.xml").expanded();
QString expectedSN = "Viking1/VISB/33322515";
QString expectedON = "Viking1/VISB/33322515";
QVector<QString> args = {
"FILE=TRUE",
QVector<QString> args = { "FILE=TRUE",
"SN=TRUE",
"OBSERVATION=TRUE"};
UserInterface options(APP_XML, args);
UserInterface options(d_APP_XML, args);
Pvl appLog;

ASSERT_TRUE(1==1);
getsn( testCube, options, &appLog );
PvlGroup results = appLog.findGroup("Results");
PvlGroup results = appLog.findGroup("Results");

EXPECT_PRED_FORMAT2(AssertQStringsEqual, results.findKeyword("Filename"), testCube->fileName());
EXPECT_PRED_FORMAT2(AssertQStringsEqual, results.findKeyword("SerialNumber"), expectedSN);
EXPECT_PRED_FORMAT2(AssertQStringsEqual, results.findKeyword("ObservationNumber"), expectedON);
Expand Down Expand Up @@ -66,9 +67,9 @@ TEST_F(DefaultCube, FunctionalTestGetsnDefaultTrue) {
Pvl appLog;
Pvl *testLabel = testCube->label();
testLabel->findObject( "IsisCube" ).deleteGroup( "Instrument" );

getsn( testCube, options, &appLog );
PvlGroup results = appLog.findGroup("Results");
PvlGroup results = appLog.findGroup("Results");

EXPECT_PRED_FORMAT2(AssertQStringsEqual, fileName , results.findKeyword("SerialNumber"));
}
Expand All @@ -83,9 +84,9 @@ TEST_F(DefaultCube, FunctionalTestGetsnDefaultFalse) {
Pvl appLog;
Pvl *testLabel = testCube->label();
testLabel->findObject( "IsisCube" ).deleteGroup( "Instrument" );

getsn( testCube, options, &appLog );
PvlGroup results = appLog.findGroup("Results");
PvlGroup results = appLog.findGroup("Results");

EXPECT_PRED_FORMAT2(AssertQStringsEqual, fileName , results.findKeyword("SerialNumber"));
}
Expand Down Expand Up @@ -114,7 +115,7 @@ TEST_F(DefaultCube, FunctionalTestGetsnFlat) {
// Test that append true appends to file
TEST_F(DefaultCube, FunctionalTestGetsnAppend) {
QFile flatFile(tempDir.path()+"testOut.txt");
QVector<QString> args = {
QVector<QString> args = {
"FORMAT=FLAT",
"TO="+flatFile.fileName(),
"APPEND=TRUE"};
Expand All @@ -133,7 +134,7 @@ TEST_F(DefaultCube, FunctionalTestGetsnAppend) {
// Test that append false overwrites file
TEST_F(DefaultCube, FunctionalTestGetsnOverwrite) {
QFile flatFile(tempDir.path()+"testOut.txt");
QVector<QString> args = {
QVector<QString> args = {
"FORMAT=FLAT",
"TO="+flatFile.fileName(),
"APPEND=FALSE"};
Expand Down