Added fix to Spice Server to accept clients with version nums >=3.5.*.* #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scsides
approved these changes
Feb 13, 2019
kledmundson
pushed a commit
that referenced
this pull request
Mar 1, 2019
* Updated the cmake version to 3.10 * Adding configurations for gtest * Tweaking things for gtest * Got gtest working and made a small example test * Updated the cmake version to be 3.10 or greater * Added test file discovery support and seperated the main into another file * Added more tests for FileName * Updated with the new testing guidelines and added new tests. * Added gmock * PixelTest (#536) * initial Pixel test * Add more test cases for Pixel * testing parameterization in Pixel test * testing function parameterization * parameterize static vs object methods * basic PixelTests implementation * clean up and more static tests * update PixelTests with float/dbl expects * Refactored stats to a functions * Modified to have cubeit remove mosaic pixel tracking info from labels. Fixes #5533 * Update cubeit.xml Fixed a typo * Fixes conda channels in Jenkinsfile & adds a MacOS node (#633) * Merged dev and cleaned up header conflicts * Update for #619. * Fix libtiff dependency (#636) (#644) * Upgrade libtiff to 4.0.10 (#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict * Moved ISIS3 conda-build recipe from ISIS3_deps repository (#650) * Fixed warning in Pixel unit tests * Removing build numbers from external libraries (#660) * Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging * Added pixel type attribute to the output image of program shadow. Fixes #5187 (#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation. * Added section for Environment and PreferemcesSetup in the Getting Started Section. (#663) * Updated .gitmodules to use https rather than ssh (#673) * Added build type release to conda recipe (#676) * Updates README with Discourse (#690) * Updates README with Discourse * Update README.md * Update README.md * Added fix to Spice Server to accept clients with version nums >=3.5.*.* (#780) * Fixed error when trying to export a compressed image using pds2hideal. Fixes #5525. (#2059) * Added capability to export a compressed image with tables missing RECORD_BYTES keyword. Added test for compressed image. * Changed names of test output cubes. * Adding explanatory comments to the meta.yaml file (#2358) * Adding explanatory comments to the recipes/meta.yaml * Replacing accidentally erased line * Added option to sort the output for consistent order in testing and added a test case * Cleaned up commented out lines in LidarData.h and .cpp * Added additional documentation for LidarData, LidarControlPoint, and lrolola2isis * Multisegment DSK support for Bullet engine (#2791) * Merged multisegment DSKs for Bullet * basic tests * removed original tests * Minor updates to download sizes and some text. (#2790) * Removed debug lines from LidarData.cpp and old comments from the lrolola2isis twoImage test * Added an additional comment about the Test format to LidarData.cpp * Phocube will export RA and declination planes even if the point is not on the planet. Fixes #4446 (#657) * Made it so that RA and Dec are added last. * Updated code to be up to standards. * Added RA and dec test. * Updated history comment. * Renamed test. * Fixed typo in documentation * Refactored code so that RA and dec are placed in the correct bands instead of moving them to the last two bands. * Updated documentation, test now checks cube label. * Fixed SummingMode keyword being set in tgocassis2isis (#2847) * Adding Expanded keyword to cassis label and modifying SummingMode keyword * Updating the window count value * Adding capacity to handle imports without Expanded tag * Setting tgocassismos to have tracking turned-on (#2856) * Adding parameter "tracking=true" to tgocassismos call to automos * Adding documentation * Fixing indentation in documentation * Updates to tgocassisrdrgen and ProcessExportPds4 to add content to exported CaSSIS Label. (#2858) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen.
kledmundson
pushed a commit
that referenced
this pull request
Mar 6, 2019
…e proj and merge of dev into branch (#3145) * Updated the cmake version to 3.10 * Adding configurations for gtest * Tweaking things for gtest * Got gtest working and made a small example test * Updated the cmake version to be 3.10 or greater * Added test file discovery support and seperated the main into another file * Added more tests for FileName * Updated with the new testing guidelines and added new tests. * Added gmock * PixelTest (#536) * initial Pixel test * Add more test cases for Pixel * testing parameterization in Pixel test * testing function parameterization * parameterize static vs object methods * basic PixelTests implementation * clean up and more static tests * update PixelTests with float/dbl expects * Refactored stats to a functions * Modified to have cubeit remove mosaic pixel tracking info from labels. Fixes #5533 * Update cubeit.xml Fixed a typo * Fixes conda channels in Jenkinsfile & adds a MacOS node (#633) * Merged dev and cleaned up header conflicts * Update for #619. * Fix libtiff dependency (#636) (#644) * Upgrade libtiff to 4.0.10 (#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict * Moved ISIS3 conda-build recipe from ISIS3_deps repository (#650) * Fixed warning in Pixel unit tests * Removing build numbers from external libraries (#660) * Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging * Added pixel type attribute to the output image of program shadow. Fixes #5187 (#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation. * Added section for Environment and PreferemcesSetup in the Getting Started Section. (#663) * Updated .gitmodules to use https rather than ssh (#673) * Added build type release to conda recipe (#676) * Updates README with Discourse (#690) * Updates README with Discourse * Update README.md * Update README.md * Added fix to Spice Server to accept clients with version nums >=3.5.*.* (#780) * Fixed error when trying to export a compressed image using pds2hideal. Fixes #5525. (#2059) * Added capability to export a compressed image with tables missing RECORD_BYTES keyword. Added test for compressed image. * Changed names of test output cubes. * Adding explanatory comments to the meta.yaml file (#2358) * Adding explanatory comments to the recipes/meta.yaml * Replacing accidentally erased line * Added option to sort the output for consistent order in testing and added a test case * Cleaned up commented out lines in LidarData.h and .cpp * Added additional documentation for LidarData, LidarControlPoint, and lrolola2isis * Multisegment DSK support for Bullet engine (#2791) * Merged multisegment DSKs for Bullet * basic tests * removed original tests * Minor updates to download sizes and some text. (#2790) * Removed debug lines from LidarData.cpp and old comments from the lrolola2isis twoImage test * Added an additional comment about the Test format to LidarData.cpp * Phocube will export RA and declination planes even if the point is not on the planet. Fixes #4446 (#657) * Made it so that RA and Dec are added last. * Updated code to be up to standards. * Added RA and dec test. * Updated history comment. * Renamed test. * Fixed typo in documentation * Refactored code so that RA and dec are placed in the correct bands instead of moving them to the last two bands. * Updated documentation, test now checks cube label. * Fixed SummingMode keyword being set in tgocassis2isis (#2847) * Adding Expanded keyword to cassis label and modifying SummingMode keyword * Updating the window count value * Adding capacity to handle imports without Expanded tag * Setting tgocassismos to have tracking turned-on (#2856) * Adding parameter "tracking=true" to tgocassismos call to automos * Adding documentation * Fixing indentation in documentation * Updates to tgocassisrdrgen and ProcessExportPds4 to add content to exported CaSSIS Label. (#2858) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Adds Issue Templates to Issues (#664) * Adds issue templates * Verbage update * Updates issue template for questions (#3131) Removed a newline in the header that I believe was causing the automatic template detection to fail. * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. (#2824) Code reviewed and tested * tgocassisrdrgen exported label re-order. (#3135) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Update label generated by tgocassisrdrgen from additional feedback (#3137) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Add StopTime to tgocassismos's Mosaic PVL group, as it is required for PDS4 export. Also, fix time formatting and east_azimuth units * Remove comment * Changed global variable proj back to projection to avoid build ambiguity errors with the std::proj
kledmundson
pushed a commit
that referenced
this pull request
Mar 13, 2019
… user interface (#3162) * Updated the cmake version to 3.10 * Adding configurations for gtest * Tweaking things for gtest * Got gtest working and made a small example test * Updated the cmake version to be 3.10 or greater * Added test file discovery support and seperated the main into another file * Added more tests for FileName * Updated with the new testing guidelines and added new tests. * Added gmock * PixelTest (#536) * initial Pixel test * Add more test cases for Pixel * testing parameterization in Pixel test * testing function parameterization * parameterize static vs object methods * basic PixelTests implementation * clean up and more static tests * update PixelTests with float/dbl expects * Refactored stats to a functions * Modified to have cubeit remove mosaic pixel tracking info from labels. Fixes #5533 * Update cubeit.xml Fixed a typo * Fixes conda channels in Jenkinsfile & adds a MacOS node (#633) * Merged dev and cleaned up header conflicts * Update for #619. * Fix libtiff dependency (#636) (#644) * Upgrade libtiff to 4.0.10 (#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict * Moved ISIS3 conda-build recipe from ISIS3_deps repository (#650) * Fixed warning in Pixel unit tests * Removing build numbers from external libraries (#660) * Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging * Added pixel type attribute to the output image of program shadow. Fixes #5187 (#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation. * Added section for Environment and PreferemcesSetup in the Getting Started Section. (#663) * Updated .gitmodules to use https rather than ssh (#673) * Added build type release to conda recipe (#676) * Updates README with Discourse (#690) * Updates README with Discourse * Update README.md * Update README.md * Added fix to Spice Server to accept clients with version nums >=3.5.*.* (#780) * Fixed error when trying to export a compressed image using pds2hideal. Fixes #5525. (#2059) * Added capability to export a compressed image with tables missing RECORD_BYTES keyword. Added test for compressed image. * Changed names of test output cubes. * Adding explanatory comments to the meta.yaml file (#2358) * Adding explanatory comments to the recipes/meta.yaml * Replacing accidentally erased line * Added option to sort the output for consistent order in testing and added a test case * Cleaned up commented out lines in LidarData.h and .cpp * Added additional documentation for LidarData, LidarControlPoint, and lrolola2isis * Multisegment DSK support for Bullet engine (#2791) * Merged multisegment DSKs for Bullet * basic tests * removed original tests * Minor updates to download sizes and some text. (#2790) * Removed debug lines from LidarData.cpp and old comments from the lrolola2isis twoImage test * Added an additional comment about the Test format to LidarData.cpp * Phocube will export RA and declination planes even if the point is not on the planet. Fixes #4446 (#657) * Made it so that RA and Dec are added last. * Updated code to be up to standards. * Added RA and dec test. * Updated history comment. * Renamed test. * Fixed typo in documentation * Refactored code so that RA and dec are placed in the correct bands instead of moving them to the last two bands. * Updated documentation, test now checks cube label. * Fixed SummingMode keyword being set in tgocassis2isis (#2847) * Adding Expanded keyword to cassis label and modifying SummingMode keyword * Updating the window count value * Adding capacity to handle imports without Expanded tag * Setting tgocassismos to have tracking turned-on (#2856) * Adding parameter "tracking=true" to tgocassismos call to automos * Adding documentation * Fixing indentation in documentation * Updates to tgocassisrdrgen and ProcessExportPds4 to add content to exported CaSSIS Label. (#2858) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Adds Issue Templates to Issues (#664) * Adds issue templates * Verbage update * Updates issue template for questions (#3131) Removed a newline in the header that I believe was causing the automatic template detection to fail. * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. (#2824) Code reviewed and tested * tgocassisrdrgen exported label re-order. (#3135) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Update label generated by tgocassisrdrgen from additional feedback (#3137) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Add StopTime to tgocassismos's Mosaic PVL group, as it is required for PDS4 export. Also, fix time formatting and east_azimuth units * Remove comment * Changed global variable proj back to projection to avoid build ambiguity errors with the std::proj * Added option to enter a list of Lidar input files * Removed deprecated code requiring target body radii to convert point coordinate sigmas from distances to angles in lrololo2isis
kledmundson
added a commit
that referenced
this pull request
Apr 30, 2019
* Updated the cmake version to 3.10 * Adding configurations for gtest * Tweaking things for gtest * Got gtest working and made a small example test * Updated the cmake version to be 3.10 or greater * Added test file discovery support and seperated the main into another file * Added more tests for FileName * Updated with the new testing guidelines and added new tests. * Added gmock * PixelTest (#536) * initial Pixel test * Add more test cases for Pixel * testing parameterization in Pixel test * testing function parameterization * parameterize static vs object methods * basic PixelTests implementation * clean up and more static tests * update PixelTests with float/dbl expects * Refactored stats to a functions * Modified to have cubeit remove mosaic pixel tracking info from labels. Fixes #5533 * Update cubeit.xml Fixed a typo * Fixes conda channels in Jenkinsfile & adds a MacOS node (#633) * Merged dev and cleaned up header conflicts * Update for #619. * Fix libtiff dependency (#636) (#644) * Upgrade libtiff to 4.0.10 (#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict * Moved ISIS3 conda-build recipe from ISIS3_deps repository (#650) * Fixed warning in Pixel unit tests * Removing build numbers from external libraries (#660) * Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging * Added pixel type attribute to the output image of program shadow. Fixes #5187 (#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation. * Added section for Environment and PreferemcesSetup in the Getting Started Section. (#663) * Updated .gitmodules to use https rather than ssh (#673) * Added build type release to conda recipe (#676) * Updates README with Discourse (#690) * Updates README with Discourse * Update README.md * Update README.md * Added fix to Spice Server to accept clients with version nums >=3.5.*.* (#780) * Fixed error when trying to export a compressed image using pds2hideal. Fixes #5525. (#2059) * Added capability to export a compressed image with tables missing RECORD_BYTES keyword. Added test for compressed image. * Changed names of test output cubes. * Adding explanatory comments to the meta.yaml file (#2358) * Adding explanatory comments to the recipes/meta.yaml * Replacing accidentally erased line * Multisegment DSK support for Bullet engine (#2791) * Merged multisegment DSKs for Bullet * basic tests * removed original tests * Minor updates to download sizes and some text. (#2790) * Phocube will export RA and declination planes even if the point is not on the planet. Fixes #4446 (#657) * Made it so that RA and Dec are added last. * Updated code to be up to standards. * Added RA and dec test. * Updated history comment. * Renamed test. * Fixed typo in documentation * Refactored code so that RA and dec are placed in the correct bands instead of moving them to the last two bands. * Updated documentation, test now checks cube label. * Fixed SummingMode keyword being set in tgocassis2isis (#2847) * Adding Expanded keyword to cassis label and modifying SummingMode keyword * Updating the window count value * Adding capacity to handle imports without Expanded tag * Setting tgocassismos to have tracking turned-on (#2856) * Adding parameter "tracking=true" to tgocassismos call to automos * Adding documentation * Fixing indentation in documentation * Updates to tgocassisrdrgen and ProcessExportPds4 to add content to exported CaSSIS Label. (#2858) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Adds Issue Templates to Issues (#664) * Adds issue templates * Verbage update * Updates issue template for questions (#3131) Removed a newline in the header that I believe was causing the automatic template detection to fail. * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. (#2824) Code reviewed and tested * tgocassisrdrgen exported label re-order. (#3135) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Update label generated by tgocassisrdrgen from additional feedback (#3137) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Add StopTime to tgocassismos's Mosaic PVL group, as it is required for PDS4 export. Also, fix time formatting and east_azimuth units * Remove comment * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint (#3146) * Fix time-formatting in reingested CaSSIS images. (#3149) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added LineEqationTests.cpp (#3152) * History entry added to cube after running sumspice. Fixes #4972. (#658) * Added WriteHistory() method to SumFinder. * Renamed method. * Refactored writeHistory to be up to isis standards. * Added history entries and updated code to be up to isis standards. * Updated history entry. * adding dedicated BundleLidarPointVector class * adding dedicated BundleLidarPointVector class * adding dedicated BundleLidarPointVector class * Various minor mods to the readme (#3165) * Added FileList test (#3168) * Added LineEqationTests.cpp * Added FileListTests.cpp Implemented an istream constructor in FileList.cpp to help with testing. * added FileList tests. implemented istream constructor for FileList.cpp to help with testing. * fixed whitespace issues in FileListTests.cpp * Update FileListTests.cpp * Cleaned up data area wording in install guide (#3170) * temp commits for testing bundle with lidar * temp commits to bundle lidar * Add ISIS3 update instructions to README (#3175) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * Updating Contributing.md (#3179) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * updated contributing guidelines * removed mentions of TC * Added LatitudeTest using Gtest (#3160) * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. * Created LatitudeTests. * Added C-Shell variable setup (#3173) * Added C-Shell variable setup * Fixed history * Made a bit more pythonic * Updates BulletDSKShape's methods for multisegment DSKs (#3181) * fixed DSK segment methods * fixed some errors * added contraints * fixed bug where an extra segment was added * Fixed memory leak in Bullet shape model (#3180) * Added AffineTests (#3166) * Add Longitude gtest (rebase of #601) (#3182) * Created gtest for Longitude class * Remove old Longitude test * Fix syntax for Longitude Tests * Remove comment * Revert "Remove old Longitude test" This reverts commit 608d3fd. * Cleaned file, organzied test cases * Fixed failing copy constructor test * Fixed bug where findrx was not adding a history blob to the input cube (#3186) * Added writeHistory to findrx. * Rearranged includes in findrx. * Removed extra exceptions writing controlnets (#3185) * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed, References #2591). (#3193) * updates to ControlPoint::ComputeApriori * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed (References #2591). Added check to IsConstrained() method to see if point type is Free, in which case we ignore stored a priori sigmas on the coordinates. * added isis error when GenericTransform::calculateInverse gets empty matrix (#3195) * Writing 0 Value Residuals to PVL (#3194) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixing errors introduced with the changes to ProcessExportPds4.cpp for the tgo sprint. (#3202) * Github/Discuss Documentation Update (#3203) * Updated website documentation to point to github and discuss where appropriate * Updated last install link * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and tru… (#3200) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Update README.md (#3204) Updated to include instructions for release candidate builds on anaconda * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * updates for bundle lidar * updates for bundle lidar * added history comment noting that piecewise polynomial functionality has been disabled to get the lidar stuff working * updates for bundle with lidar
kledmundson
added a commit
that referenced
this pull request
Apr 30, 2019
* Updated the cmake version to 3.10 * Adding configurations for gtest * Tweaking things for gtest * Got gtest working and made a small example test * Updated the cmake version to be 3.10 or greater * Added test file discovery support and seperated the main into another file * Added more tests for FileName * Updated with the new testing guidelines and added new tests. * Added gmock * PixelTest (#536) * initial Pixel test * Add more test cases for Pixel * testing parameterization in Pixel test * testing function parameterization * parameterize static vs object methods * basic PixelTests implementation * clean up and more static tests * update PixelTests with float/dbl expects * Refactored stats to a functions * Modified to have cubeit remove mosaic pixel tracking info from labels. Fixes #5533 * Update cubeit.xml Fixed a typo * Fixes conda channels in Jenkinsfile & adds a MacOS node (#633) * Merged dev and cleaned up header conflicts * Update for #619. * Fix libtiff dependency (#636) (#644) * Upgrade libtiff to 4.0.10 (#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict * Moved ISIS3 conda-build recipe from ISIS3_deps repository (#650) * Fixed warning in Pixel unit tests * Removing build numbers from external libraries (#660) * Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging * Added pixel type attribute to the output image of program shadow. Fixes #5187 (#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation. * Added section for Environment and PreferemcesSetup in the Getting Started Section. (#663) * Updated .gitmodules to use https rather than ssh (#673) * Added build type release to conda recipe (#676) * Updates README with Discourse (#690) * Updates README with Discourse * Update README.md * Update README.md * Added fix to Spice Server to accept clients with version nums >=3.5.*.* (#780) * Fixed error when trying to export a compressed image using pds2hideal. Fixes #5525. (#2059) * Added capability to export a compressed image with tables missing RECORD_BYTES keyword. Added test for compressed image. * Changed names of test output cubes. * Adding explanatory comments to the meta.yaml file (#2358) * Adding explanatory comments to the recipes/meta.yaml * Replacing accidentally erased line * Multisegment DSK support for Bullet engine (#2791) * Merged multisegment DSKs for Bullet * basic tests * removed original tests * Minor updates to download sizes and some text. (#2790) * Phocube will export RA and declination planes even if the point is not on the planet. Fixes #4446 (#657) * Made it so that RA and Dec are added last. * Updated code to be up to standards. * Added RA and dec test. * Updated history comment. * Renamed test. * Fixed typo in documentation * Refactored code so that RA and dec are placed in the correct bands instead of moving them to the last two bands. * Updated documentation, test now checks cube label. * Fixed SummingMode keyword being set in tgocassis2isis (#2847) * Adding Expanded keyword to cassis label and modifying SummingMode keyword * Updating the window count value * Adding capacity to handle imports without Expanded tag * Setting tgocassismos to have tracking turned-on (#2856) * Adding parameter "tracking=true" to tgocassismos call to automos * Adding documentation * Fixing indentation in documentation * Updates to tgocassisrdrgen and ProcessExportPds4 to add content to exported CaSSIS Label. (#2858) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Adds Issue Templates to Issues (#664) * Adds issue templates * Verbage update * Updates issue template for questions (#3131) Removed a newline in the header that I believe was causing the automatic template detection to fail. * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. (#2824) Code reviewed and tested * tgocassisrdrgen exported label re-order. (#3135) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Update label generated by tgocassisrdrgen from additional feedback (#3137) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Add StopTime to tgocassismos's Mosaic PVL group, as it is required for PDS4 export. Also, fix time formatting and east_azimuth units * Remove comment * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint (#3146) * Fix time-formatting in reingested CaSSIS images. (#3149) * Updated truthdata for ProcessExportPds4 class to match updates made for CaSSIS sprint * Fix trailing Z time-format in tgocassis2isis when reingesting images exported from ISIS3 * Added LineEqationTests.cpp (#3152) * History entry added to cube after running sumspice. Fixes #4972. (#658) * Added WriteHistory() method to SumFinder. * Renamed method. * Refactored writeHistory to be up to isis standards. * Added history entries and updated code to be up to isis standards. * Updated history entry. * adding dedicated BundleLidarPointVector class * adding dedicated BundleLidarPointVector class * adding dedicated BundleLidarPointVector class * Various minor mods to the readme (#3165) * Added FileList test (#3168) * Added LineEqationTests.cpp * Added FileListTests.cpp Implemented an istream constructor in FileList.cpp to help with testing. * added FileList tests. implemented istream constructor for FileList.cpp to help with testing. * fixed whitespace issues in FileListTests.cpp * Update FileListTests.cpp * Cleaned up data area wording in install guide (#3170) * temp commits for testing bundle with lidar * temp commits to bundle lidar * Add ISIS3 update instructions to README (#3175) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * Updating Contributing.md (#3179) * Merged multisegment DSKs for Bullet * updated with update instructions * isis->isis3 * added header * updated contributing guidelines * removed mentions of TC * Added LatitudeTest using Gtest (#3160) * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. * Created LatitudeTests. * Added C-Shell variable setup (#3173) * Added C-Shell variable setup * Fixed history * Made a bit more pythonic * Updates BulletDSKShape's methods for multisegment DSKs (#3181) * fixed DSK segment methods * fixed some errors * added contraints * fixed bug where an extra segment was added * Fixed memory leak in Bullet shape model (#3180) * Added AffineTests (#3166) * Add Longitude gtest (rebase of #601) (#3182) * Created gtest for Longitude class * Remove old Longitude test * Fix syntax for Longitude Tests * Remove comment * Revert "Remove old Longitude test" This reverts commit 608d3fd. * Cleaned file, organzied test cases * Fixed failing copy constructor test * Fixed bug where findrx was not adding a history blob to the input cube (#3186) * Added writeHistory to findrx. * Rearranged includes in findrx. * Removed extra exceptions writing controlnets (#3185) * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed, References #2591). (#3193) * updates to ControlPoint::ComputeApriori * Fixed bug where focal plane measured x,y coordinates were not set if the cam->SetImage call failed (References #2591). Added check to IsConstrained() method to see if point type is Free, in which case we ignore stored a priori sigmas on the coordinates. * added isis error when GenericTransform::calculateInverse gets empty matrix (#3195) * Writing 0 Value Residuals to PVL (#3194) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixing errors introduced with the changes to ProcessExportPds4.cpp for the tgo sprint. (#3202) * Github/Discuss Documentation Update (#3203) * Updated website documentation to point to github and discuss where appropriate * Updated last install link * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and tru… (#3200) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Update README.md (#3204) Updated to include instructions for release candidate builds on anaconda * Added gtests for Displacement.cpp, removed Displacement unitTest and truthfile. (#3209) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Updated README data area instructions (#3214) * Fixed data area instructions in README and some links * Fixed bold in block quote * Fixed legacy install guide link * extra l * Testing indentation list * Testing indentation list again * Testing indentation list code snippet * Minor wording clean up * Removed extra number * Removed duplicate Mars Odyssey entry * Updates to the build recipe for ISIS releases for the 3.7.0 release candidate. (#3205) * Minor modifications for RC build * Small modification to version in the recipe/meta.yaml * Updating release stage in isis/version * Added Area3DTests.cpp (#3216) * Added BasisFunctionTests.cpp. Removed BasisFunction unit test and truthfile. * changed expectedOutput values for some of the tests * Made tests for Displacement.cpp using gtest. removed Displacement unitTest and truthfile. * Added Area3DTests.cpp, removed Area3D truthfile and unit test. * included TestUtilities.h for use with exception testing, added a test for teh Area3D '=' operator * changed formatting to adhere to USGS coding standards * re-addedd the unit test and truth file * gllssi2isis Original Label Fix (#3226) * Allowed writting of residuals when value is zero to controlnet pvl * Updated ControlNetVersioner unit test * Fixed pvl labels original pvl labels not being written to the resulting cube. * Updated docstrings and history for updated methods * Removed the need to set the output cube pixel type * Reverted proceeimport changes * Set the dimensions in the process before processing * Added missing 1 in a history record * Reverted and applied a more appropriate fix * Used outfile obtained at the beginning of the program * Added history comment to app xml * Removed accidental comma (#3230) * Update README.md (#3232) Update readability * Modifying files for conda build for ISIS3.7.0_RC2 (#3229) * Modifying files for conda build for ISIS3.7.0_RC_2 * Changes to modifications until issue #3231 can be completed * Small typo * One final added comment for clarification * Adding tab completion for tcsh on conda activation (#3244) * updates for bundle lidar * updates for bundle lidar * added history comment noting that piecewise polynomial functionality has been disabled to get the lidar stuff working * updates for bundle with lidar * removed commented code
dcookastro
added a commit
that referenced
this pull request
May 21, 2019
…usions added to jigsaw (#3297) * Updated the cmake version to 3.10 * Adding configurations for gtest * Tweaking things for gtest * Got gtest working and made a small example test * Updated the cmake version to be 3.10 or greater * Added test file discovery support and seperated the main into another file * Added more tests for FileName * Updated with the new testing guidelines and added new tests. * Added gmock * PixelTest (#536) * initial Pixel test * Add more test cases for Pixel * testing parameterization in Pixel test * testing function parameterization * parameterize static vs object methods * basic PixelTests implementation * clean up and more static tests * update PixelTests with float/dbl expects * Refactored stats to a functions * Modified to have cubeit remove mosaic pixel tracking info from labels. Fixes #5533 * Update cubeit.xml Fixed a typo * Fixes conda channels in Jenkinsfile & adds a MacOS node (#633) * Merged dev and cleaned up header conflicts * Update for #619. * Fix libtiff dependency (#636) (#644) * Upgrade libtiff to 4.0.10 (#636) * Switch libtiff to 4.0.9 or higher to remove geotiff conflict * Moved ISIS3 conda-build recipe from ISIS3_deps repository (#650) * Fixed warning in Pixel unit tests * Removing build numbers from external libraries (#660) * Moved ISIS3 conda-build recipe from ISIS3_deps repository * Un-pinned non-astro build numbers * Removing build numbers from external libraries in the environment and meta.yeml files * Final merging * Added pixel type attribute to the output image of program shadow. Fixes #5187 (#659) * Removed bolding of some text to decrease distraction. * Fixed some typos. * Reworded documentation. * Added section for Environment and PreferemcesSetup in the Getting Started Section. (#663) * Updated .gitmodules to use https rather than ssh (#673) * Added build type release to conda recipe (#676) * Updates README with Discourse (#690) * Updates README with Discourse * Update README.md * Update README.md * Added fix to Spice Server to accept clients with version nums >=3.5.*.* (#780) * Fixed error when trying to export a compressed image using pds2hideal. Fixes #5525. (#2059) * Added capability to export a compressed image with tables missing RECORD_BYTES keyword. Added test for compressed image. * Changed names of test output cubes. * Adding explanatory comments to the meta.yaml file (#2358) * Adding explanatory comments to the recipes/meta.yaml * Replacing accidentally erased line * Added option to sort the output for consistent order in testing and added a test case * Cleaned up commented out lines in LidarData.h and .cpp * Added additional documentation for LidarData, LidarControlPoint, and lrolola2isis * Multisegment DSK support for Bullet engine (#2791) * Merged multisegment DSKs for Bullet * basic tests * removed original tests * Minor updates to download sizes and some text. (#2790) * Removed debug lines from LidarData.cpp and old comments from the lrolola2isis twoImage test * Added an additional comment about the Test format to LidarData.cpp * Phocube will export RA and declination planes even if the point is not on the planet. Fixes #4446 (#657) * Made it so that RA and Dec are added last. * Updated code to be up to standards. * Added RA and dec test. * Updated history comment. * Renamed test. * Fixed typo in documentation * Refactored code so that RA and dec are placed in the correct bands instead of moving them to the last two bands. * Updated documentation, test now checks cube label. * Fixed SummingMode keyword being set in tgocassis2isis (#2847) * Adding Expanded keyword to cassis label and modifying SummingMode keyword * Updating the window count value * Adding capacity to handle imports without Expanded tag * Setting tgocassismos to have tracking turned-on (#2856) * Adding parameter "tracking=true" to tgocassismos call to automos * Adding documentation * Fixing indentation in documentation * Updates to tgocassisrdrgen and ProcessExportPds4 to add content to exported CaSSIS Label. (#2858) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Adds Issue Templates to Issues (#664) * Adds issue templates * Verbage update * Updates issue template for questions (#3131) Removed a newline in the header that I believe was causing the automatic template detection to fail. * Added gtest for ID and split TestUtilities into a cpp and h file to fix duplicate symbol error when building. (#2824) Code reviewed and tested * tgocassisrdrgen exported label re-order. (#3135) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Update label generated by tgocassisrdrgen from additional feedback (#3137) * Add 32-bit ISIS Special Pixel Constants to ProcessExportPds4 * Add ability to set title and version id in exported PDS4 produce in tgocassisrdrgen and ProcessExportPds4 API * Fix bug that occurs when exporting mosaics with Archive groups and fixed min/max lat/lon to east/west bounding box positive east flip bug * Added docs. * Update schema to most recent versions and comment-out schema that isn't used (temporarily) in tgocassisrdrgen. * Added reorder function to ProcessExportPds4 to reorder xml files generated in the wrong order for PDS4 and added cassis-specific schema * Add StopTime to tgocassismos's Mosaic PVL group, as it is required for PDS4 export. Also, fix time formatting and east_azimuth units * Remove comment * Changed global variable proj back to projection to avoid build ambiguity errors with the std::proj * Added option to enter a list of Lidar input files * Removed deprecated code requiring target body radii to convert point coordinate sigmas from distances to angles in lrololo2isis * Updated documentation in SpiceRotation, BundleAdjust, and lrolola2isis * Added multipleInputs test to the lrolola2isis test suite * Added exclusion to jigsaw to prevent running Lidar without solving for spacecraft position * Changed history date to today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spiceinit is failing if the ISIS3 client version is not equal to 3.5.2 This fix eases that restriction, and spiceinit will only fail if the ISIS3 client version is less than or equal to 3.5.. When we have more time, the spiceit server contained within a docker container will be a stable alternative to the current spice server.
Description
Related Issue
Motivation and Context
Spice server is not accepting any connections from the latest release of ISIS3.
How Has This Been Tested?
It hasn't. This is a quick and dirty fix to get the spice server back up. A longer term solution would
be to place the spiceit server application within a docker container and test that extensively.
N/A
Spice server is completely separate from the rest of ISIS3 so no changes to the rest of ISIS3 are possible.
Screenshots (if appropriate):
Types of changes
Checklist:
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: