Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sdist and wheels content #28

Merged
merged 9 commits into from
Sep 30, 2024
Merged

Conversation

dolfim-ibm
Copy link
Contributor

@dolfim-ibm dolfim-ibm commented Sep 27, 2024

Resolves #24: missing sdist in pypi index
Resolves #25: installing pybind11 as a build time python package dependency
Refs #27: add missing windows pyd files

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm dolfim-ibm marked this pull request as ready for review September 29, 2024 15:50
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dolfim-ibm dolfim-ibm merged commit f3febc5 into main Sep 30, 2024
29 checks passed
@dolfim-ibm dolfim-ibm deleted the fix-sdist-and-wheels-content branch September 30, 2024 15:46
PeterStaar-IBM added a commit that referenced this pull request Oct 7, 2024
* fix: sdist and wheels content (#28)

* missing sdist in pypi index
* installing pybind11 as a build time python package dependency
* add missing windows pyd files

---------

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>

* chore: bump version to 1.3.1 [skip ci]

* chore: remove security issue (#34)

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* fix: python version in wheels (#31)

[skip ci]

---------

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>

* feat: build using system deps (#33)


---------

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>

* chore: bump version to 1.4.0 [skip ci]

* fix: windows build properly linking to system libraries (#36)

Signed-off-by: rmdg88 <rmdg88@gmail.com>

* chore: bump version to 1.4.1 [skip ci]

* updated the cxxopts cmake to deal with system-dependencies

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* fixed the includes

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* it compiles finally

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* fixed the poetry.lock

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* trying to fix the rhel build script

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* trying to fix the rhel build script (2)

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* trying to fix the rhel build script (3)

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* revert to cxxopts v2.2.0

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* updating to cxxopts v3.2.0

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

---------

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Co-authored-by: Michele Dolfi <97102151+dolfim-ibm@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rui Dias Gomes <66125272+rmdg88@users.noreply.github.com>
cau-git pushed a commit that referenced this pull request Oct 7, 2024
* fix: sdist and wheels content (#28)

* missing sdist in pypi index
* installing pybind11 as a build time python package dependency
* add missing windows pyd files

---------

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>

* chore: bump version to 1.3.1 [skip ci]

* chore: remove security issue (#34)

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* fix: python version in wheels (#31)

[skip ci]

---------

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>

* feat: build using system deps (#33)

---------

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>

* chore: bump version to 1.4.0 [skip ci]

* fix: windows build properly linking to system libraries (#36)

Signed-off-by: rmdg88 <rmdg88@gmail.com>

* chore: bump version to 1.4.1 [skip ci]

* updated the cxxopts cmake to deal with system-dependencies

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* fixed the includes

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* it compiles finally

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* fixed the poetry.lock

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* trying to fix the rhel build script

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* trying to fix the rhel build script (2)

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* trying to fix the rhel build script (3)

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* revert to cxxopts v2.2.0

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

* updating to cxxopts v3.2.0

Signed-off-by: Peter Staar <taa@zurich.ibm.com>

---------

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Peter Staar <taa@zurich.ibm.com>
Signed-off-by: rmdg88 <rmdg88@gmail.com>
Co-authored-by: Michele Dolfi <97102151+dolfim-ibm@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rui Dias Gomes <66125272+rmdg88@users.noreply.github.com>
Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installing pybind11 as a build time python package dependency missing sdist in pypi index
2 participants