-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: python version in wheels #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dolfim-ibm
commented
Oct 1, 2024
•
edited
Loading
edited
- Fix the duplicate publish of sdist
- Fix wheels containing wrong python modules
- Python 3.9 CI is disabled, since there is no pairing docling version for it
- More tests
- Validate that poetry using the right python version
- Validate that the .so is contained in the wheels
- Validate that the wheels contain the expected python version
- Try using docling-parse with the latest docling
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
PeterStaar-IBM
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go!
PeterStaar-IBM
added a commit
that referenced
this pull request
Oct 7, 2024
* fix: sdist and wheels content (#28) * missing sdist in pypi index * installing pybind11 as a build time python package dependency * add missing windows pyd files --------- Signed-off-by: Michele Dolfi <dol@zurich.ibm.com> * chore: bump version to 1.3.1 [skip ci] * chore: remove security issue (#34) Signed-off-by: Peter Staar <taa@zurich.ibm.com> * fix: python version in wheels (#31) [skip ci] --------- Signed-off-by: Michele Dolfi <dol@zurich.ibm.com> * feat: build using system deps (#33) --------- Signed-off-by: Michele Dolfi <dol@zurich.ibm.com> * chore: bump version to 1.4.0 [skip ci] * fix: windows build properly linking to system libraries (#36) Signed-off-by: rmdg88 <rmdg88@gmail.com> * chore: bump version to 1.4.1 [skip ci] * updated the cxxopts cmake to deal with system-dependencies Signed-off-by: Peter Staar <taa@zurich.ibm.com> * fixed the includes Signed-off-by: Peter Staar <taa@zurich.ibm.com> * it compiles finally Signed-off-by: Peter Staar <taa@zurich.ibm.com> * fixed the poetry.lock Signed-off-by: Peter Staar <taa@zurich.ibm.com> * trying to fix the rhel build script Signed-off-by: Peter Staar <taa@zurich.ibm.com> * trying to fix the rhel build script (2) Signed-off-by: Peter Staar <taa@zurich.ibm.com> * trying to fix the rhel build script (3) Signed-off-by: Peter Staar <taa@zurich.ibm.com> * revert to cxxopts v2.2.0 Signed-off-by: Peter Staar <taa@zurich.ibm.com> * updating to cxxopts v3.2.0 Signed-off-by: Peter Staar <taa@zurich.ibm.com> --------- Signed-off-by: Michele Dolfi <dol@zurich.ibm.com> Signed-off-by: Peter Staar <taa@zurich.ibm.com> Signed-off-by: rmdg88 <rmdg88@gmail.com> Co-authored-by: Michele Dolfi <97102151+dolfim-ibm@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Rui Dias Gomes <66125272+rmdg88@users.noreply.github.com>
cau-git
pushed a commit
that referenced
this pull request
Oct 7, 2024
* fix: sdist and wheels content (#28) * missing sdist in pypi index * installing pybind11 as a build time python package dependency * add missing windows pyd files --------- Signed-off-by: Michele Dolfi <dol@zurich.ibm.com> * chore: bump version to 1.3.1 [skip ci] * chore: remove security issue (#34) Signed-off-by: Peter Staar <taa@zurich.ibm.com> * fix: python version in wheels (#31) [skip ci] --------- Signed-off-by: Michele Dolfi <dol@zurich.ibm.com> * feat: build using system deps (#33) --------- Signed-off-by: Michele Dolfi <dol@zurich.ibm.com> * chore: bump version to 1.4.0 [skip ci] * fix: windows build properly linking to system libraries (#36) Signed-off-by: rmdg88 <rmdg88@gmail.com> * chore: bump version to 1.4.1 [skip ci] * updated the cxxopts cmake to deal with system-dependencies Signed-off-by: Peter Staar <taa@zurich.ibm.com> * fixed the includes Signed-off-by: Peter Staar <taa@zurich.ibm.com> * it compiles finally Signed-off-by: Peter Staar <taa@zurich.ibm.com> * fixed the poetry.lock Signed-off-by: Peter Staar <taa@zurich.ibm.com> * trying to fix the rhel build script Signed-off-by: Peter Staar <taa@zurich.ibm.com> * trying to fix the rhel build script (2) Signed-off-by: Peter Staar <taa@zurich.ibm.com> * trying to fix the rhel build script (3) Signed-off-by: Peter Staar <taa@zurich.ibm.com> * revert to cxxopts v2.2.0 Signed-off-by: Peter Staar <taa@zurich.ibm.com> * updating to cxxopts v3.2.0 Signed-off-by: Peter Staar <taa@zurich.ibm.com> --------- Signed-off-by: Michele Dolfi <dol@zurich.ibm.com> Signed-off-by: Peter Staar <taa@zurich.ibm.com> Signed-off-by: rmdg88 <rmdg88@gmail.com> Co-authored-by: Michele Dolfi <97102151+dolfim-ibm@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Rui Dias Gomes <66125272+rmdg88@users.noreply.github.com> Signed-off-by: Christoph Auer <cau@zurich.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.