Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add animation for announcements / notices #1789

Closed
MoritzWeber0 opened this issue Sep 11, 2024 · 0 comments · Fixed by #1796
Closed

Add animation for announcements / notices #1789

MoritzWeber0 opened this issue Sep 11, 2024 · 0 comments · Fixed by #1796
Labels
good first issue

Comments

@MoritzWeber0
Copy link
Member

Announcements are lazy loaded. Once it is loaded, the page "jumps". It should be animated so that it moved slowly and gives the user a chance to recognize it.
zusorio added a commit that referenced this issue Sep 12, 2024
@zusorio
feat: Animate load-in of notices
d438346 
Animate the load-in of notices to make the layout shift less jarring.

Closes #1789
@zusorio zusorio mentioned this issue Sep 12, 2024
Merged
MoritzWeber0 added a commit that referenced this issue Sep 12, 2024
@zusorio @MoritzWeber0
feat: Animate load-in of notices
6c20a73 
Animate the load-in of notices to make the layout shift less jarring.

Closes #1789

It also updates the code to the latest code styles:
- Stories for notice and alerts were added.
- NgFor / NgIf were replaced.
- The service was moved from the general services directory to a context base directory.
- Notices in the NoticeWrapperService is now a BehaviourSubject.
- Custom Types and Functions were replaced with the OpenAPI schema.

Co-authored-by: MoritzWeber0 <kontakt@moritz-weber.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
Capella Collaboration Roadmap 🚀
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Animate load-in of notices DSD-DBS/capella-collab-manager
1 participant
@MoritzWeber0