feat: Animate load-in of notices #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A Storybook preview is available for commit f19d0d1. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1796 +/- ##
=======================================
Coverage 84.06% 84.06%
=======================================
Files 186 186
Lines 6144 6144
Branches 676 676
=======================================
Hits 5165 5165
Misses 831 831
Partials 148 148 ☔ View full report in Codecov by Sentry. |
Animate the load-in of notices to make the layout shift less jarring. Closes #1789 It also updates the code to the latest code styles: - Stories for notice and alerts were added. - NgFor / NgIf were replaced. - The service was moved from the general services directory to a context base directory. - Notices in the NoticeWrapperService is now a BehaviourSubject. - Custom Types and Functions were replaced with the OpenAPI schema. Co-authored-by: MoritzWeber0 <kontakt@moritz-weber.net>
MoritzWeber0
force-pushed
the
animate-notices
branch
from
d438346
to
6c20a73
Compare
|
MoritzWeber0
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
I added some changes to apply the latest code style to the old components:
- Stories for notice and alerts were added.
- NgFor / NgIf were replaced.
- The service was moved from the general services directory to a context base directory.
- Notices in the NoticeWrapperService is now a BehaviourSubject.
- Custom Types and Functions were replaced with the OpenAPI schema.
After those changes it's good to be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animate the load-in of notices to make the layout shift less jarring.
Closes #1789