Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The types of panel.add will confused #283

Closed
mortalYoung opened this issue Jul 27, 2021 · 1 comment · Fixed by #300
Closed

The types of panel.add will confused #283

mortalYoung opened this issue Jul 27, 2021 · 1 comment · Fixed by #300
Assignees
@wewoor
Labels
refactoring Refactor
Milestone
0.9.0-alpha.4

Comments

@mortalYoung
Copy link
Collaborator

Description

When I use molecule.panel.add to add a new panel in molecule. According to code snippet in IDE, I get title and name, but I don't really know about the different between title and name. Same as render and renderPane

image
snippet for name

image
snippet for title too

image
the most confused is the render and the renderPane
@mortalYoung
Copy link
Collaborator Author

#182 serivece review should be aware of this problem

@wewoor wewoor added the refactoring Refactor label Jul 28, 2021
@wewoor wewoor added this to the 0.9.0-alpha.4 milestone Jul 28, 2021
@wewoor wewoor mentioned this issue Jul 30, 2021
Merged
@wewoor wewoor closed this as completed Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wewoor wewoor

Labels
refactoring Refactor
Projects
None yet
Milestone
0.9.0-alpha.4
Development

Successfully merging a pull request may close this issue.

refactor: update the PanelService DTStack/molecule
2 participants
@wewoor @mortalYoung