refactor: update the PanelService #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProfBramble
pushed a commit
that referenced
this pull request
Aug 4, 2021
* refactor: rename the PanelService methods * docs: add comments for the IPanelService interface * feat: add setActive method in the PanelService * refactor: remove the render function from IPanelItem interface * docs: add a comment for the title attribute of IPanelItem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
简介
根据 Naming Rules 重构PanelService的方法明，部分接口类型，和文档完善
主要变更
maximizeRestore重命名为toggleMaximizegetById重命名为getPanelrender方法 The types of panel.add will confused #283setActive(id: string)函数这里单独添加 title 属性的原因是，之前不支持 Tooltip 组件，所以要独立添加 title 属性，name 后期会设计成
ReactNode类型Resolved #283