-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review the Services #182
Milestone
Comments
ServicesUseless methods or the naming refactoring: IActivityBarService #289
ISidebarService
IExplorerService #291
IFolderTreeService
IMenuBarService
INotificationService
IProblemsServiceshowHideProblems -> toggleProblems ISearchService
IStatusBarService
参考 |
IExplorerService
IMenuBarService有一个多余的 INotificationService这个不考虑改成 |
This was referenced Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
我觉得这个讨论是有提醒到我的,#176 (comment)
togglePanelMaximized 本身更倾向是对 事件(Action) 本身对一种响应, Service 里面还是偏主动操作的抽象比较好;
我看了下,其他 Service 也有这种命名。后面统一再 Review 下 Service吧
Originally posted by @wewoor in #176 (comment)
The text was updated successfully, but these errors were encountered: