-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design and Extract LayoutService #176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumiao
changed the title
Design and Extract LayoutService
【WIP】Design and Extract LayoutService
Jun 10, 2021
mortalYoung
reviewed
Jun 11, 2021
mumiao
changed the title
【WIP】Design and Extract LayoutService
Design and Extract LayoutService
Jun 16, 2021
mumiao
added
enhancement
New feature or request
refactoring
Refactor
and removed
feature
labels
Jun 16, 2021
wewoor
reviewed
Jun 16, 2021
wewoor
reviewed
Jun 17, 2021
Closed
wewoor
reviewed
Jun 18, 2021
constructor() { | ||
super(); | ||
this.state = container.resolve(LayoutModel); | ||
this._container = document.getElementById(ID_APP) || document.body; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layoutService container 的初始化,必须要再 MoleculeProvide DidMount 中去执行,ID_APP 目前是指Workbench View, 这个会存在实例化 layoutService 的时候,container 始终是 body 元素的问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #173