Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(activitybar): update the ActivityBarService interfaces #289

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Jul 28, 2021

Description

  1. 重命名 addBar 为 add;
  2. 重命名 toggleContextMenuCheckedStatus 为 toggleContextMenuChecked
  3. 更新�ActivityBarService 接口文档

@wewoor wewoor requested a review from mortalYoung July 28, 2021 06:51
@wewoor wewoor self-assigned this Jul 28, 2021
@wewoor wewoor added this to the 0.9.0-alpha.4 milestone Jul 28, 2021
@wewoor wewoor mentioned this pull request Jul 28, 2021
@wewoor wewoor added the refactoring Refactor label Jul 28, 2021
@wewoor wewoor requested a review from mortalYoung August 3, 2021 06:34
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit a400950 into main Aug 3, 2021
@wewoor wewoor deleted the refactor/activityBar branch August 3, 2021 12:31
ProfBramble pushed a commit that referenced this pull request Aug 5, 2021
* refactor: rename the activityService addBar to add

* refactor: rename ActivityBarService toggleContextMenuCheckedStatus to toggleContextMenuChecked

* docs: correct the grammar of comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants