Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update ExplorerService interfaces #291

Merged
merged 2 commits into from
Jul 28, 2021
Merged

refactor: update ExplorerService interfaces #291

merged 2 commits into from
Jul 28, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Jul 28, 2021

Description

  • 修改 ExplorerService 方法前缀，delete -> remove, edit -> update;
  • 修改 ExplorerService 接口文档；
  • 移除 updateRender 方法

@wewoor wewoor requested a review from mortalYoung July 28, 2021 08:47
@wewoor wewoor self-assigned this Jul 28, 2021
@wewoor wewoor added the refactoring Refactor label Jul 28, 2021
@wewoor wewoor added this to the 0.9.0-alpha.4 milestone Jul 28, 2021
@wewoor wewoor mentioned this pull request Jul 28, 2021
Closed
mortalYoung
mortalYoung approved these changes Jul 28, 2021
View reviewed changes
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit d8a6e43 into main Jul 28, 2021
@wewoor wewoor deleted the refactor/explorer branch July 28, 2021 09:55
ProfBramble pushed a commit that referenced this pull request Aug 4, 2021
@wewoor @ProfBramble
refactor: update ExplorerService interfaces (#291)
a3321b6 
* refactor: rename the function prefix of ExplorerService edit to update, delete to remove

* refactor: remove the updateRender method from ExplorerService
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortalYoung mortalYoung mortalYoung approved these changes

Assignees

@wewoor wewoor

Labels
refactoring Refactor
Projects
None yet
Milestone
0.9.0-alpha.4
Development

Successfully merging this pull request may close these issues.
2 participants
@wewoor @mortalYoung