Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB - Fix a bunch of bugs #75

Merged
merged 17 commits into from
Jul 11, 2024

Commits on Jul 9, 2024

  1. No code changes ... yet

    * Improve the name of first parameter to `rgb_assign_color()` to reflect it's a bitmask of which LEDs to assign the color to.
    * Formatting changes to more easily compare similar code.
    henrygab committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    43d2197 View commit details
    Browse the repository at this point in the history
  2. Formatting changes only

    * Each `T_CONFIG_...` option is listed on its own line.  This improves the ability to diff changes.  It also allows reading the options in code editor. (no ultra-long lines!)
    
    * Align the elmeents of of `sub_prompts[]`.  This allows easier understanding of the differences between each array element.
    
    * Use named initializers for `main_cfg` and `main_prompt` variables.  This simply adds clarity when reviewing the code.
    henrygab committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    12688e3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0449c0a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    37d1930 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8f7e71e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f1e28f5 View commit details
    Browse the repository at this point in the history
  7. Add enumeration for led effects

    No behavioral change.  Just makes it harder to make mistakes later.  Static assertions added for the same reason.
    henrygab committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b02dbad View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b548142 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    ad6fb23 View commit details
    Browse the repository at this point in the history
  2. Multiple small QoL improvements.

    Rewrote function for setting brightness from menu for increased clarity.
    
    Fix LED config name to reflect its purpose:
    Specifically, it doesn't store the LED brightness, but rather stores a divisor value (i.e., the inverse of storing the brightness).
    
    Store the LED effect as an enum.
    (self-documenting, better debugger visualizations, ...)
    
    Delete some dead code.
    henrygab committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    8f91bc9 View commit details
    Browse the repository at this point in the history
  3. RGB: initial cleanup

    henrygab committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5bd9872 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ad18cf5 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2edfbc7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0ff67ae View commit details
    Browse the repository at this point in the history
  7. Add new default rgb effect (gentle glow)

    Eventually, will have this use the user's chosen color.
    Importantly, it uses higher brightness for edge pixels than for those facing same direction as the screen.
    henrygab committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    4015c76 View commit details
    Browse the repository at this point in the history
  8. fix build error on rev8

    henrygab committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    e8ff467 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    78c3e02 View commit details
    Browse the repository at this point in the history