-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RGB - Fix a bunch of bugs #75
Merged
DangerousPrototypes
merged 17 commits into
DangerousPrototypes:main
from
henrygab:RGB_QoL_dev
Jul 11, 2024
Merged
RGB - Fix a bunch of bugs #75
DangerousPrototypes
merged 17 commits into
DangerousPrototypes:main
from
henrygab:RGB_QoL_dev
Jul 11, 2024
Commits on Jul 9, 2024
-
* Improve the name of first parameter to `rgb_assign_color()` to reflect it's a bitmask of which LEDs to assign the color to. * Formatting changes to more easily compare similar code.
Configuration menu - View commit details
-
Copy full SHA for 43d2197 - Browse repository at this point
Copy the full SHA 43d2197View commit details -
* Each `T_CONFIG_...` option is listed on its own line. This improves the ability to diff changes. It also allows reading the options in code editor. (no ultra-long lines!) * Align the elmeents of of `sub_prompts[]`. This allows easier understanding of the differences between each array element. * Use named initializers for `main_cfg` and `main_prompt` variables. This simply adds clarity when reviewing the code.
Configuration menu - View commit details
-
Copy full SHA for 12688e3 - Browse repository at this point
Copy the full SHA 12688e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0449c0a - Browse repository at this point
Copy the full SHA 0449c0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37d1930 - Browse repository at this point
Copy the full SHA 37d1930View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f7e71e - Browse repository at this point
Copy the full SHA 8f7e71eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1e28f5 - Browse repository at this point
Copy the full SHA f1e28f5View commit details -
Add enumeration for led effects
No behavioral change. Just makes it harder to make mistakes later. Static assertions added for the same reason.
Configuration menu - View commit details
-
Copy full SHA for b02dbad - Browse repository at this point
Copy the full SHA b02dbadView commit details -
Configuration menu - View commit details
-
Copy full SHA for b548142 - Browse repository at this point
Copy the full SHA b548142View commit details
Commits on Jul 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ad6fb23 - Browse repository at this point
Copy the full SHA ad6fb23View commit details -
Multiple small QoL improvements.
Rewrote function for setting brightness from menu for increased clarity. Fix LED config name to reflect its purpose: Specifically, it doesn't store the LED brightness, but rather stores a divisor value (i.e., the inverse of storing the brightness). Store the LED effect as an enum. (self-documenting, better debugger visualizations, ...) Delete some dead code.
Configuration menu - View commit details
-
Copy full SHA for 8f91bc9 - Browse repository at this point
Copy the full SHA 8f91bc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bd9872 - Browse repository at this point
Copy the full SHA 5bd9872View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad18cf5 - Browse repository at this point
Copy the full SHA ad18cf5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2edfbc7 - Browse repository at this point
Copy the full SHA 2edfbc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ff67ae - Browse repository at this point
Copy the full SHA 0ff67aeView commit details -
Add new default rgb effect (gentle glow)
Eventually, will have this use the user's chosen color. Importantly, it uses higher brightness for edge pixels than for those facing same direction as the screen.
Configuration menu - View commit details
-
Copy full SHA for 4015c76 - Browse repository at this point
Copy the full SHA 4015c76View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8ff467 - Browse repository at this point
Copy the full SHA e8ff467View commit details
Commits on Jul 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 78c3e02 - Browse repository at this point
Copy the full SHA 78c3e02View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.