Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cyb417 test bp over fn #26

Merged
merged 5 commits into from
Nov 27, 2019
Merged

Cyb417 test bp over fn #26

merged 5 commits into from
Nov 27, 2019

Conversation

sadaocasino
Copy link

No description provided.

justefg
justefg reviewed Nov 7, 2019
View reviewed changes
simulator/tests/randpa_finality_tests.cpp Outdated
runner.load_graph(g);
runner.add_stop_task(15 * runner.get_slot_ms());
runner.run<RandpaNode>();
for (auto i = 0; i<nodes_amount; ++i) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spaces around operations
i < nodes_amount

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added braces {}, assert, more readable listing of node types, deleted test without BP (randpa_finality.two_full_nodes), added spaces to operators.

Copy link
Author

@sadaocasino sadaocasino Nov 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test randpa_finality.fullnodes_over_round_ring does not pass after adding
auto seed = time(NULL); std::srand(seed); std::cout << "Random number generator seeded to " << time(NULL) << std::endl; std::cout << seed;
in DAObet/simulator/main.cpp.
All the time testcase has different get_block_height(runner.get_db(i).last_irreversible_block_id()) for nodes.

This problem occurs in this test only.

@sadaocasino sadaocasino force-pushed the CYB417-test-BP-over-FN branch 3 times, most recently from 28368b0 to 0cbdb04 Compare November 11, 2019 10:18
@algys algys force-pushed the CYB417-test-BP-over-FN branch 2 times, most recently from 2dbc958 to af807d6 Compare November 22, 2019 13:28
@algys algys requested review from algys and removed request for justefg November 25, 2019 12:52
@sadaocasino sadaocasino merged commit de5d362 into develop Nov 27, 2019
@adrianopol adrianopol deleted the CYB417-test-BP-over-FN branch March 11, 2020 09:56
adrianopol pushed a commit that referenced this pull request May 15, 2020
# This is a combination of 186 commits.
6c09577 
# This is the 1st commit message:

various improvements

# This is the commit message #2:

new hash

# This is the commit message #3:

fix for script path

# This is the commit message #4:

fixes

# This is the commit message #5:

fixes

# This is the commit message #6:

fixes

# This is the commit message #7:

fixes

# This is the commit message #8:

fixes

# This is the commit message #9:

fixes

# This is the commit message #10:

fixes

# This is the commit message #11:

fixes

# This is the commit message #12:

fixes

# This is the commit message #13:

fixes

# This is the commit message #14:

fixes

# This is the commit message #15:

fixes

# This is the commit message #16:

fixes

# This is the commit message #17:

fixes

# This is the commit message #18:

fixes

# This is the commit message #19:

fixes

# This is the commit message #20:

fixes

# This is the commit message #21:

fixes

# This is the commit message #22:

fixes

# This is the commit message #23:

fixes

# This is the commit message #24:

fixes

# This is the commit message #25:

fixes

# This is the commit message #26:

testing

# This is the commit message #27:

testing

# This is the commit message #28:

testing

# This is the commit message #29:

testing

# This is the commit message #30:

testing

# This is the commit message #31:

testing

# This is the commit message #32:

testing

# This is the commit message #33:

testing

# This is the commit message #34:

testing

# This is the commit message #35:

testing

# This is the commit message #36:

testing

# This is the commit message #37:

testing

# This is the commit message #38:

testing

# This is the commit message #39:

testing

# This is the commit message #40:

testing

# This is the commit message #41:

testing

# This is the commit message #42:

testing

# This is the commit message #43:

testing

# This is the commit message #44:

fixes

# This is the commit message #45:

fixes

# This is the commit message #46:

fixes

# This is the commit message #47:

fixes

# This is the commit message #48:

fixes

# This is the commit message #49:

fixes

# This is the commit message #50:

fixes

# This is the commit message #51:

fixes

# This is the commit message #52:

fixes

# This is the commit message #53:

fixes

# This is the commit message #54:

fixes

# This is the commit message #55:

fixes

# This is the commit message #56:

fixes

# This is the commit message #57:

fixes

# This is the commit message #58:

fixes

# This is the commit message #59:

fixes

# This is the commit message #60:

fixes

# This is the commit message #61:

fixes

# This is the commit message #62:

fixes

# This is the commit message #63:

fixes

# This is the commit message #64:

fixes

# This is the commit message #65:

fixes

# This is the commit message #66:

fixes

# This is the commit message #67:

fixes

# This is the commit message #68:

fixes

# This is the commit message #69:

fixes

# This is the commit message #70:

fixes

# This is the commit message #71:

fixes

# This is the commit message #72:

fixes

# This is the commit message #73:

fixes

# This is the commit message #74:

fixes

# This is the commit message #75:

fixes

# This is the commit message #76:

fixes

# This is the commit message #77:

fixes

# This is the commit message #78:

fixes

# This is the commit message #79:

more testing

# This is the commit message #80:

testing

# This is the commit message #81:

fixes

# This is the commit message #82:

fixes

# This is the commit message #83:

fixes

# This is the commit message #84:

fixes

# This is the commit message #85:

fixes

# This is the commit message EOSIO#86:

fixes

# This is the commit message EOSIO#87:

fixes

# This is the commit message EOSIO#88:

fixes

# This is the commit message EOSIO#89:

fixes

# This is the commit message EOSIO#90:

fixes

# This is the commit message EOSIO#91:

fixes

# This is the commit message EOSIO#92:

fixes

# This is the commit message EOSIO#93:

propagate-environment for buildkite-agent

# This is the commit message EOSIO#94:

propagate-environment for buildkite-agent

# This is the commit message EOSIO#95:

propagate-environment for buildkite-agent

# This is the commit message EOSIO#96:

propagate-environment for buildkite-agent

# This is the commit message EOSIO#97:

fixes

# This is the commit message EOSIO#98:

fixes

# This is the commit message EOSIO#99:

fixes

# This is the commit message EOSIO#100:

fixes

# This is the commit message EOSIO#101:

fixes

# This is the commit message EOSIO#102:

fixes

# This is the commit message EOSIO#103:

fixes

# This is the commit message EOSIO#104:

fixes

# This is the commit message EOSIO#105:

fixes

# This is the commit message EOSIO#106:

fixes

# This is the commit message EOSIO#107:

fixes

# This is the commit message EOSIO#108:

fixes

# This is the commit message EOSIO#109:

fixes

# This is the commit message EOSIO#110:

fixes

# This is the commit message EOSIO#111:

fixes

# This is the commit message EOSIO#112:

fixes

# This is the commit message EOSIO#113:

fixes

# This is the commit message EOSIO#114:

fixes

# This is the commit message EOSIO#115:

fixes

# This is the commit message EOSIO#116:

fixes

# This is the commit message EOSIO#117:

fixes

# This is the commit message EOSIO#118:

fixes

# This is the commit message EOSIO#119:

fixes

# This is the commit message EOSIO#120:

fixes

# This is the commit message EOSIO#121:

fixes

# This is the commit message EOSIO#122:

fixes

# This is the commit message EOSIO#123:

fixes

# This is the commit message EOSIO#124:

fixes

# This is the commit message EOSIO#125:

fixes

# This is the commit message EOSIO#126:

fixes

# This is the commit message EOSIO#127:

fixes

# This is the commit message EOSIO#128:

fixes

# This is the commit message EOSIO#129:

fixes

# This is the commit message EOSIO#130:

fixes

# This is the commit message EOSIO#131:

fixes

# This is the commit message EOSIO#132:

fixes

# This is the commit message EOSIO#133:

fixes

# This is the commit message EOSIO#134:

fixes

# This is the commit message EOSIO#135:

fixes

# This is the commit message EOSIO#136:

fixes

# This is the commit message EOSIO#137:

fixes

# This is the commit message EOSIO#138:

fixes

# This is the commit message EOSIO#139:

fixes

# This is the commit message EOSIO#140:

fixes

# This is the commit message EOSIO#141:

fixes

# This is the commit message EOSIO#142:

fixes

# This is the commit message EOSIO#143:

fixes

# This is the commit message EOSIO#144:

fixes

# This is the commit message EOSIO#145:

fixes

# This is the commit message EOSIO#146:

fixes

# This is the commit message EOSIO#147:

fixes

# This is the commit message EOSIO#148:

fixes

# This is the commit message EOSIO#149:

fixes

# This is the commit message EOSIO#150:

fixes

# This is the commit message EOSIO#151:

fixes

# This is the commit message EOSIO#152:

fixes

# This is the commit message EOSIO#153:

testing

# This is the commit message EOSIO#154:

fixes

# This is the commit message EOSIO#155:

fixes

# This is the commit message EOSIO#156:

fixes

# This is the commit message EOSIO#157:

fixes

# This is the commit message EOSIO#158:

fixes

# This is the commit message EOSIO#159:

fixes

# This is the commit message EOSIO#160:

fixes

# This is the commit message EOSIO#161:

fixes

# This is the commit message EOSIO#162:

fixes

# This is the commit message EOSIO#163:

fixes

# This is the commit message EOSIO#164:

fixes

# This is the commit message EOSIO#165:

fixes

# This is the commit message EOSIO#166:

fixes

# This is the commit message EOSIO#167:

fixes

# This is the commit message EOSIO#168:

fixes

# This is the commit message EOSIO#169:

fixes

# This is the commit message EOSIO#170:

fixes

# This is the commit message EOSIO#171:

fixes

# This is the commit message EOSIO#172:

fixes

# This is the commit message EOSIO#173:

fixes

# This is the commit message EOSIO#174:

fixes

# This is the commit message EOSIO#175:

fixes

# This is the commit message EOSIO#176:

fixes

# This is the commit message EOSIO#177:

fixes

# This is the commit message EOSIO#178:

fixes

# This is the commit message EOSIO#179:

fixes

# This is the commit message EOSIO#180:

fixes

# This is the commit message EOSIO#181:

fixes

# This is the commit message EOSIO#182:

fixes

# This is the commit message EOSIO#183:

fixes

# This is the commit message EOSIO#184:

fixes

# This is the commit message EOSIO#185:

fixes

# This is the commit message EOSIO#186:

fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justefg justefg justefg approved these changes

@algys algys algys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadaocasino @justefg @algys