Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all unit tests with AWS_DEFAULT_PROFILE set to a special region #1498

Closed
hannes-ucsc opened this issue Dec 4, 2019 · 1 comment
Closed

Run all unit tests with AWS_DEFAULT_PROFILE set to a special region #1498

hannes-ucsc opened this issue Dec 4, 2019 · 1 comment
Assignees
@nadove-ucsc
Labels
compliance [subject] Information and software security debt [type] A defect incurring continued engineering cost demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team ssp [process] Resolution is reflected in SSP test [subject] Unit and integration test code

Comments

@hannes-ucsc
Copy link
Member

hannes-ucsc commented Dec 4, 2019 •
edited by unito-bot
Loading

There are now various places in the unit tests where us-east-1 is hard-coded as the AWS region. This is the region that our real deployments live in. Apparently, some moto mocks require a region to be set (the one for SQS, for example). To accommodate those but also as a second line of defence against mocks becoming ineffective and real resources being used, the test setup at a very high level, potentially AzulTestCase.setupClass() should patch AWS_DEFAULT_REGION to some other region, potentially even a made up one.

┆Issue is synchronized with this Jira Story
┆Project Name: azul
┆Issue Number: AZUL-921
@hannes-ucsc hannes-ucsc added debt [type] A defect incurring continued engineering cost test [subject] Unit and integration test code compliance [subject] Information and software security labels Dec 4, 2019
@github-actions github-actions bot added the orange [process] Done by the Azul team label Dec 4, 2019
@theathorn
Copy link

Hannes: PR not a strong enough improvement. No substantially better solution available at this time.

@theathorn theathorn assigned hannes-ucsc and unassigned nadove-ucsc Apr 24, 2020
hannes-ucsc pushed a commit that referenced this issue May 5, 2020
@nadove-ucsc @hannes-ucsc
Use exotic AWS region for unit tests (#1498)
6722202
hannes-ucsc added a commit that referenced this issue May 5, 2020
@hannes-ucsc
Use exotic AWS region for unit tests (#1498, PR #1710)
1dd6f80
@melainalegaspi melainalegaspi added the demoed [process] Successfully demonstrated to team label May 12, 2020
@hannes-ucsc hannes-ucsc added the ssp [process] Resolution is reflected in SSP label Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadove-ucsc nadove-ucsc

Labels
compliance [subject] Information and software security debt [type] A defect incurring continued engineering cost demoed [process] Successfully demonstrated to team orange [process] Done by the Azul team ssp [process] Resolution is reflected in SSP test [subject] Unit and integration test code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hannes-ucsc @theathorn @melainalegaspi @nadove-ucsc