Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Index hca_dev_20201203__20210507 into dcp2 on dev (#3049) #3050

Conversation

dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented May 11, 2021

Author

  • PR title references issue
  • Title of main commit references issue
  • PR is linked to Zenhub issue

Author (reindex)

  • Added r tag to commit title or this PR does not require reindexing
  • Added reindex label to PR or this PR does not require reindexing

Author (freebies & chains)

  • Freebies are blocked on this PR or there are no freebies in this PR
  • Freebies are referenced in commit titles or there are no freebies in this PR
  • This PR is blocked by previous PR in the chain or this PR is not chained to another PR
  • Added chain label to the blocking PR or this PR is not chained to another PR

Author (upgrading)

  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading
  • Added u tag to commit title or this PR does not require upgrading
  • Added upgrade label to PR or this PR does not require upgrading

Author (requirements, before every review)

  • Ran make requirements_update or this PR leaves requirements*.txt, common.mk and Makefile untouched
  • Added R tag to commit title or this PR leaves requirements*.txt untouched
  • Added reqs label to PR or this PR leaves requirements*.txt untouched

Author (before every review)

  • make integration_test passes in personal deployment or this PR does not touch functionality that could break the IT
  • Rebased branch on develop, squashed old fixups

Primary reviewer (after approval)

  • Commented on demo expectations or labelled PR as no demo
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Moved ticket to Approved column
  • Assigned PR to an operator

Operator (before pushing merge the commit)

  • Checked reindex label and r commit title tag
  • Checked that Demo expectations are clear or PR is labeled as no demo
  • Rebased and squashed branch
  • Sanity-checked history
  • Pushed PR branch to Github
  • Branch pushed to Gitlab or PR is labeled no sandbox
  • Build passes in sandbox and added sandbox label or PR is labeled no sandbox
  • Started reindex in sandbox or this PR does not require reindexing sandbox
  • Checked for failures in sandbox or this PR does not require reindexing sandbox
  • Added PR reference to merge commit title
  • Collected commit title tags in merge commit title
  • Moved linked issue to Merged column
  • Pushed merge commit to Github

Operator (after pushing the merge commit)

  • Moved freebies to Merged column or there are no freebies in this PR
  • Shortened the PR chain or this PR is not the base of another PR
  • Verified that N reviews labelling is accurate
  • Pushed merge commit to Gitlab or this changes can be pushed later, together with another PR
  • Deleted PR branch from Github and Gitlab

Operator (reindex)

  • Started reindex in dev or this PR does not require reindexing or does not target dev
  • Checked for failures in dev or this PR does not require reindexing or does not target dev
  • Started reindex in prod or this PR does not require reindexing or does not target prod
  • Checked for failures in prod or this PR does not require reindexing or does not target prod

Operator

  • Unassigned PR

@github-actions github-actions bot added the orange [process] Done by the Azul team label May 11, 2021
@dsotirho-ucsc dsotirho-ucsc added the reindex:dev [process] PR requires reindexing dev label May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #3050 (be23a3c) into develop (eb2ee02) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3050   +/-   ##
========================================
  Coverage    82.64%   82.64%           
========================================
  Files          117      117           
  Lines        12246    12246           
========================================
  Hits         10121    10121           
  Misses        2125     2125           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb2ee02...be23a3c. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.165% when pulling be23a3c on issues/danielsotirhos/3049-index-snapshot-hca_dev_20201203__20210507 into eb2ee02 on develop.

@dsotirho-ucsc dsotirho-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label May 12, 2021
@dsotirho-ucsc dsotirho-ucsc merged commit 08f1f53 into develop May 12, 2021
@dsotirho-ucsc dsotirho-ucsc deleted the issues/danielsotirhos/3049-index-snapshot-hca_dev_20201203__20210507 branch May 12, 2021 14:52
@dsotirho-ucsc dsotirho-ucsc removed their assignment May 12, 2021
@dsotirho-ucsc
Copy link
Contributor Author

5 messages found in dev fail queue:

(azul1) daniel@Crispin ~/repo/azul1 $ python scripts/manage_queues.py list
2021-05-12 12:00:39,574 INFO    MainThread: Listing queues

Queue Name                          Messages Available  Messages In Flight  Messages Delayed

2021-05-12 12:00:39,621 INFO    MainThread: Found credentials in environment variables.
azul-notifications-dev                      0                   0                  0
azul-notifications_retry-dev                0                   0                  0
azul-tallies-dev.fifo                       0                   0                  0
azul-tallies_retry-dev.fifo                 0                   0                  0
azul-tallies_fail-dev.fifo                  0                   0                  0
azul-notifications_fail-dev                 5                   0                  0

All failures relate to bundles with known issues:

The following 4 bundles mentioned in #2873

"MessageId": "b5d3fba6-a613-4b05-9665-fc7cfcb4b225",
"bundle_uuid": "ae338c4e-650f-545b-8631-3c8d755aa2f9",
"bundle_version": "2020-12-03T00:00:01.000000Z"
"SentTimestamp": "2021-05-11T21:23:53.995000-07:00",
"MessageId": "6805b20c-d641-438c-9c01-92ea55e5169f",
"bundle_uuid": "9d0f5cd1-0ef6-5eed-8dd7-f15d36a34185",
"bundle_version": "2020-12-03T00:00:01.000000Z"
"SentTimestamp": "2021-05-11T21:23:53.424000-07:00",
"MessageId": "9fefa2f0-c99f-45dc-ba73-20e7b83cd739",
"bundle_uuid": "c12a6ca2-3234-5182-ad0b-f8c2fb881ab5",
"bundle_version": "2020-12-03T00:00:01.000000Z"
"SentTimestamp": "2021-05-11T21:23:57.474000-07:00",
"MessageId": "4f8ecea4-5991-45a2-9d2e-5f6992c84b46",
"bundle_uuid": "40733888-3b9f-500e-84fd-1a18a64aadbe",
"bundle_version": "2020-12-03T00:00:01.000000Z"
"SentTimestamp": "2021-05-11T21:23:57.474000-07:00",

And the following 1 bundle mentioned in #2870

"MessageId": "8796aa64-ea89-4119-85eb-7e1c8e97f0bd",
"bundle_uuid": "94565940-7b2f-5fd7-beb1-dc309687fe09",
"bundle_version": "2021-02-10T17:01:03.177554Z"
"SentTimestamp": "2021-05-11T21:23:50.607000-07:00",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
orange [process] Done by the Azul team reindex:dev [process] PR requires reindexing dev sandbox [process] Resolution is being verified in sandbox deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants