Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index hca_dev_20201203___20210524_lattice into dcp2 on dev (#3075) #3081

Conversation

nadove-ucsc
Copy link
Contributor

@nadove-ucsc nadove-ucsc commented May 26, 2021

#3075)

Author

  • PR title references issue
  • Title of main commit references issue
  • PR is linked to Zenhub issue

Author (reindex)

  • Added r tag to commit title or this PR does not require reindexing
  • Added reindex label to PR or this PR does not require reindexing

Author (freebies & chains)

  • Freebies are blocked on this PR or there are no freebies in this PR
  • Freebies are referenced in commit titles or there are no freebies in this PR
  • This PR is blocked by previous PR in the chain or this PR is not chained to another PR
  • Added chain label to the blocking PR or this PR is not chained to another PR

Author (upgrading)

  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading
  • Added u tag to commit title or this PR does not require upgrading
  • Added upgrade label to PR or this PR does not require upgrading

Author (requirements, before every review)

  • Ran make requirements_update or this PR leaves requirements*.txt, common.mk and Makefile untouched
  • Added R tag to commit title or this PR leaves requirements*.txt untouched
  • Added reqs label to PR or this PR leaves requirements*.txt untouched

Author (before every review)

  • make integration_test passes in personal deployment or this PR does not touch functionality that could break the IT
  • Rebased branch on develop, squashed old fixups

Primary reviewer (after approval)

  • Commented in issue about demo expectations or labelled issue as no demo
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Moved ticket to Approved column
  • Assigned PR to an operator

Operator (before pushing merge the commit)

  • Checked reindex label and r commit title tag
  • Checked that demo expectations are clear or issue is labeled as no demo
  • Rebased and squashed branch
  • Sanity-checked history
  • Pushed PR branch to Github
  • Branch pushed to Gitlab or PR is labeled no sandbox
  • Build passes in sandbox and added sandbox label or PR is labeled no sandbox
  • Started reindex in sandbox or this PR does not require reindexing sandbox
  • Checked for failures in sandbox or this PR does not require reindexing sandbox
  • Added PR reference to merge commit title
  • Collected commit title tags in merge commit title
  • Moved linked issue to Merged column
  • Pushed merge commit to Github

Operator (after pushing the merge commit)

  • Moved freebies to Merged column or there are no freebies in this PR
  • Shortened the PR chain or this PR is not the base of another PR
  • Verified that N reviews labelling is accurate
  • Pushed merge commit to Gitlab or this changes can be pushed later, together with another PR
  • Deleted PR branch from Github and Gitlab

Operator (reindex)

  • Started reindex in dev or this PR does not require reindexing or does not target dev
  • Checked for failures in dev or this PR does not require reindexing or does not target dev
  • Started reindex in prod or this PR does not require reindexing or does not target prod
  • Checked for failures in prod or this PR does not require reindexing or does not target prod

Operator

  • Unassigned PR

@github-actions github-actions bot added the orange [process] Done by the Azul team label May 26, 2021
@nadove-ucsc nadove-ucsc changed the title Index snapshot hca_dev_20201203___20210524_lattice into dcp2 on dev (… Index hca_dev_20201203___20210524_lattice into dcp2 on dev (#3075) May 26, 2021
@nadove-ucsc nadove-ucsc added the reindex:dev [process] PR requires reindexing dev label May 26, 2021
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #3081 (7d3edbe) into develop (7d3edbe) will not change coverage.
The diff coverage is n/a.

❗ Current head 7d3edbe differs from pull request most recent head d4d4c58. Consider uploading reports for the commit d4d4c58 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3081   +/-   ##
========================================
  Coverage    82.50%   82.50%           
========================================
  Files          115      115           
  Lines        12269    12269           
========================================
  Hits         10123    10123           
  Misses        2146     2146           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d3edbe...d4d4c58. Read the comment docs.

@coveralls
Copy link

coveralls commented May 26, 2021

Coverage Status

Coverage remained the same at 83.081% when pulling d4d4c58 on issues/noah-aviel-dove/3075-index-hca_dev_20201203___20210524_lattice-dcp2-dev into 7d3edbe on develop.

@nadove-ucsc
Copy link
Contributor Author

IT failed, cancelling review request

@dsotirho-ucsc dsotirho-ucsc removed their assignment May 26, 2021
@nadove-ucsc nadove-ucsc force-pushed the issues/noah-aviel-dove/3075-index-hca_dev_20201203___20210524_lattice-dcp2-dev branch from 46ce785 to d4d4c58 Compare May 26, 2021 18:55
@hannes-ucsc hannes-ucsc added the no demo [process] Not to be demonstrated at the end of the sprint label May 26, 2021
@nadove-ucsc nadove-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label May 26, 2021
@nadove-ucsc
Copy link
Contributor Author

No failures from reindexing sandbox.

@nadove-ucsc nadove-ucsc merged commit 8ce3166 into develop May 26, 2021
@nadove-ucsc nadove-ucsc added the 0 reviews [process] Lead didn't request any changes label May 27, 2021
@nadove-ucsc nadove-ucsc deleted the issues/noah-aviel-dove/3075-index-hca_dev_20201203___20210524_lattice-dcp2-dev branch May 27, 2021 04:45
@nadove-ucsc
Copy link
Contributor Author

Reindex completed with five failures as expected:

40733888-3b9f-500e-84fd-1a18a64aadbe
94565940-7b2f-5fd7-beb1-dc309687fe09
9d0f5cd1-0ef6-5eed-8dd7-f15d36a34185
ae338c4e-650f-545b-8631-3c8d755aa2f9
c12a6ca2-3234-5182-ad0b-f8c2fb881ab5  

4 of these correspond to #2873 , the other is presumably from #2870 but that ticket doesn't seem to mention the bundle UUID.

@nadove-ucsc nadove-ucsc removed their assignment May 27, 2021
@nadove-ucsc
Copy link
Contributor Author

Confirmed that the last UUID (94565940...) corresponds to #2870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 reviews [process] Lead didn't request any changes no demo [process] Not to be demonstrated at the end of the sprint orange [process] Done by the Azul team reindex:dev [process] PR requires reindexing dev sandbox [process] Resolution is being verified in sandbox deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants