Fix: Extraction of matrix_cell_count is wrong (#3097)

[dsotirho-ucsc]

Author

• PR title references issue
• Title of main commit references issue
• PR is linked to Zenhub issue

Author (reindex)

• Added r tag to commit title _{or this PR does not require reindexing}
• Added reindex label to PR _{or this PR does not require reindexing}

Author (freebies & chains)

• Freebies are blocked on this PR _{or there are no freebies in this PR}
• Freebies are referenced in commit titles _{or there are no freebies in this PR}
• This PR is blocked by previous PR in the chain _{or this PR is not chained to another PR}
• Added chain label to the blocking PR _{or this PR is not chained to another PR}

Author (upgrading)

• Documented upgrading of deployments in UPGRADING.rst _{or this PR does not require upgrading}
• Added u tag to commit title _{or this PR does not require upgrading}
• Added upgrade label to PR _{or this PR does not require upgrading}

Author (requirements, before every review)

• Ran make requirements_update _{or this PR leaves requirements*.txt, common.mk and Makefile untouched}
• Added R tag to commit title _{or this PR leaves requirements*.txt untouched}
• Added reqs label to PR _{or this PR leaves requirements*.txt untouched}

Author (before every review)

• make integration_test passes in personal deployment _{or this PR does not touch functionality that could break the IT}
• Rebased branch on develop, squashed old fixups

Primary reviewer (after approval)

• Commented in issue about demo expectations _{or labelled issue as no demo}
• Decided if PR can be labeled no sandbox
• PR title is appropriate as title of merge commit
• Moved ticket to Approved column
• Assigned PR to an operator

Operator (before pushing merge the commit)

• Checked reindex label and r commit title tag
• Checked that demo expectations are clear _{or issue is labeled as no demo}
• Rebased and squashed branch
• Sanity-checked history
• Pushed PR branch to Github
• Branch pushed to Gitlab _{or PR is labeled no sandbox}
• Build passes in sandbox and added sandbox label _{or PR is labeled no sandbox}
• Started reindex in sandbox _{or this PR does not require reindexing sandbox}
• Checked for failures in sandbox _{or this PR does not require reindexing sandbox}
• Added PR reference to merge commit title
• Collected commit title tags in merge commit title
• Moved linked issue to Merged column
• Pushed merge commit to Github

Operator (after pushing the merge commit)

• Moved freebies to Merged column _{or there are no freebies in this PR}
• Shortened the PR chain _{or this PR is not the base of another PR}
• Verified that N reviews labelling is accurate
• Pushed merge commit to Gitlab _{or this changes can be pushed later, together with another PR}
• Deleted PR branch from Github and Gitlab

Operator (reindex)

• Started reindex in dev _{or this PR does not require reindexing or does not target dev}
• Checked for failures in dev _{or this PR does not require reindexing or does not target dev}
• Started reindex in prod _{or this PR does not require reindexing or does not target prod}
• Checked for failures in prod _{or this PR does not require reindexing or does not target prod}

Operator

• Unassigned PR

[codecov]

Codecov Report

Merging #3101 (e408e18) into develop (17c5354) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #3101   +/-   ##
========================================
  Coverage    82.50%   82.50%           
========================================
  Files          115      115           
  Lines        12279    12279           
========================================
  Hits         10131    10131           
  Misses        2148     2148           

Impacted Files	Coverage Δ
src/azul/plugins/metadata/hca/aggregate.py	97.72% <ø> (ø)
src/azul/plugins/metadata/hca/transform.py	99.27% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c5354...e408e18. Read the comment docs.

[coveralls]

Coverage remained the same at 83.078% when pulling e408e18 on issues/danielsotirhos/3097-fix-extract-matrix-cell-count-is-wrong into 17c5354 on develop.

[achave11-ucsc]

LGTM. Approved!

[achave11-ucsc]

Comma necessary?

[nadove-ucsc]

No failures after reindexing sandbox.

[nadove-ucsc]

Failures after reindexing dev:

40733888-3b9f-500e-84fd-1a18a64aadbe
94565940-7b2f-5fd7-beb1-dc309687fe09
9d0f5cd1-0ef6-5eed-8dd7-f15d36a34185
ae338c4e-650f-545b-8631-3c8d755aa2f9
c12a6ca2-3234-5182-ad0b-f8c2fb881ab5

Which match the expected failures from #2870 and #2873.