Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove organismAgeValue term facet from service response (#2824) #3437

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

achave11-ucsc
Copy link
Member

@achave11-ucsc achave11-ucsc commented Sep 16, 2021

#2824

Author

  • PR title references issue
  • PR title matches issue title (preceded by Fix: for bugs) or there is a good reason why they're different
  • Title of main commit references issue
  • PR is connected to Zenhub issue and description links to issue

Author (reindex)

  • Added r tag to commit title or this PR does not require reindexing
  • Added reindex label to PR or this PR does not require reindexing

Author (freebies & chains)

  • Freebies are blocked on this PR or there are no freebies in this PR
  • Freebies are referenced in commit titles or there are no freebies in this PR
  • This PR is blocked by previous PR in the chain or this PR is not chained to another PR
  • Added chain label to the blocking PR or this PR is not chained to another PR

Author (upgrading)

  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading
  • Added u tag to commit title or this PR does not require upgrading
  • Added upgrade label to PR or this PR does not require upgrading
  • Added announcement to PR description or this PR does not require announcement

Author (requirements, before every review)

  • Ran make requirements_update or this PR leaves requirements*.txt, common.mk and Makefile untouched
  • Added R tag to commit title or this PR leaves requirements*.txt untouched
  • Added reqs label to PR or this PR leaves requirements*.txt untouched

Author (before every review)

  • make integration_test passes in personal deployment or this PR does not touch functionality that could break the IT
  • Rebased branch on develop, squashed old fixups

Primary reviewer (after approval)

  • Commented in issue about demo expectations or labelled issue as no demo
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Moved ticket to Approved column
  • Assigned PR to an operator

Operator (before pushing merge the commit)

  • Checked reindex label and r commit title tag
  • Checked that demo expectations are clear or issue is labeled as no demo
  • Rebased and squashed branch
  • Sanity-checked history
  • Pushed PR branch to Github
  • Branch pushed to Gitlab and added sandbox label or PR is labeled no sandbox
  • Build passed in sandbox or PR is labeled no sandbox
  • Started reindex in sandbox or this PR does not require reindexing sandbox
  • Checked for failures in sandbox or this PR does not require reindexing sandbox
  • Added PR reference to merge commit title
  • Collected commit title tags in merge commit title
  • Moved linked issue to Merged column
  • Pushed merge commit to Github

Operator (after pushing the merge commit)

  • Made announcement requested by author or PR description does not contain an announcement
  • Moved freebies to Merged column or there are no freebies in this PR
  • Shortened the PR chain or this PR is not the base of another PR
  • Verified that N reviews labelling is accurate
  • Pushed merge commit to Gitlab or this changes can be pushed later, together with another PR
  • Deleted PR branch from Github and Gitlab

Operator (reindex)

  • Started reindex in dev or this PR does not require reindexing or does not target dev
  • Checked for failures in dev or this PR does not require reindexing or does not target dev
  • Started reindex in prod or this PR does not require reindexing or does not target prod
  • Checked for failures in prod or this PR does not require reindexing or does not target prod

Operator

  • Unassigned PR

@achave11-ucsc achave11-ucsc added the reindex:dev [process] PR requires reindexing dev label Sep 16, 2021
@github-actions github-actions bot added the orange [process] Done by the Azul team label Sep 16, 2021
@achave11-ucsc achave11-ucsc removed the request for review from dsotirho-ucsc September 16, 2021 21:42
@achave11-ucsc achave11-ucsc force-pushed the issues/achave11/2824-rm-organismAgeValue-facet branch 4 times, most recently from 4b7d008 to 3dcc768 Compare September 17, 2021 19:01
@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #3437 (bdde3d5) into develop (bdde3d5) will not change coverage.
The diff coverage is n/a.

❗ Current head bdde3d5 differs from pull request most recent head 2bd436d. Consider uploading reports for the commit 2bd436d to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3437   +/-   ##
========================================
  Coverage    82.55%   82.55%           
========================================
  Files          123      123           
  Lines        14246    14246           
========================================
  Hits         11761    11761           
  Misses        2485     2485           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdde3d5...2bd436d. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 17, 2021

Coverage Status

Coverage remained the same at 82.794% when pulling 2bd436d on issues/achave11/2824-rm-organismAgeValue-facet into bdde3d5 on develop.

Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@dsotirho-ucsc dsotirho-ucsc removed their assignment Sep 20, 2021
@achave11-ucsc achave11-ucsc force-pushed the issues/achave11/2824-rm-organismAgeValue-facet branch 2 times, most recently from ede74e4 to a6a0e3c Compare September 21, 2021 17:12
Copy link
Member

@hannes-ucsc hannes-ucsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but we can't merge until blocker DataBiosphere/data-browser#1947 lands in dev and prod.

@hannes-ucsc hannes-ucsc added the hold warm [process] PR can't land just yet but needs to be rebased daily label Sep 21, 2021
@hannes-ucsc hannes-ucsc removed their assignment Sep 21, 2021
@hannes-ucsc hannes-ucsc added the 0 reviews [process] Lead didn't request any changes label Sep 21, 2021
@achave11-ucsc achave11-ucsc force-pushed the issues/achave11/2824-rm-organismAgeValue-facet branch from a6a0e3c to ea7c54a Compare September 23, 2021 17:00
@achave11-ucsc
Copy link
Member Author

As per Slack conv. this changes can be merged without breaking DB.

@hannes-ucsc hannes-ucsc removed the hold warm [process] PR can't land just yet but needs to be rebased daily label Sep 23, 2021
@hannes-ucsc
Copy link
Member

Sounds good. In that case, rebase and request review, please.

@nadove-ucsc nadove-ucsc force-pushed the issues/achave11/2824-rm-organismAgeValue-facet branch from ea7c54a to d08a832 Compare September 28, 2021 08:40
@nadove-ucsc nadove-ucsc added the sandbox [process] Resolution is being verified in sandbox deployment label Sep 28, 2021
@nadove-ucsc nadove-ucsc force-pushed the issues/achave11/2824-rm-organismAgeValue-facet branch from d08a832 to 2bd436d Compare September 28, 2021 23:08
@nadove-ucsc
Copy link
Contributor

Failed in IT. Trying early_reindex.

@nadove-ucsc
Copy link
Contributor

No reindex failures. Queues are all empty.

@nadove-ucsc
Copy link
Contributor

Retrying IT passed after the early_reindex.

@nadove-ucsc nadove-ucsc merged commit eba9a93 into develop Sep 29, 2021
@nadove-ucsc nadove-ucsc deleted the issues/achave11/2824-rm-organismAgeValue-facet branch September 29, 2021 00:38
@nadove-ucsc
Copy link
Contributor

IT for merge commit failed in develop as expected. Starting early_reindex.

@nadove-ucsc
Copy link
Contributor

No unexpected failures. 5 failed bundles, all expected due to #2873 and #2870:

40733888-3b9f-500e-84fd-1a18a64aadbe
94565940-7b2f-5fd7-beb1-dc309687fe09
9d0f5cd1-0ef6-5eed-8dd7-f15d36a34185
ae338c4e-650f-545b-8631-3c8d755aa2f9
c12a6ca2-3234-5182-ad0b-f8c2fb881ab5

@nadove-ucsc nadove-ucsc removed their assignment Sep 29, 2021
@nadove-ucsc
Copy link
Contributor

Merge build passed post-reindex 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 reviews [process] Lead didn't request any changes orange [process] Done by the Azul team reindex:dev [process] PR requires reindexing dev sandbox [process] Resolution is being verified in sandbox deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants