-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove organismAgeValue term facet from service response (#2824) #3437
Remove organismAgeValue term facet from service response (#2824) #3437
Conversation
4b7d008
to
3dcc768
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3437 +/- ##
========================================
Coverage 82.55% 82.55%
========================================
Files 123 123
Lines 14246 14246
========================================
Hits 11761 11761
Misses 2485 2485 Continue to review full report at Codecov.
|
3dcc768
to
732352a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
ede74e4
to
a6a0e3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but we can't merge until blocker DataBiosphere/data-browser#1947 lands in dev
and prod
.
a6a0e3c
to
ea7c54a
Compare
As per Slack conv. this changes can be merged without breaking DB. |
Sounds good. In that case, rebase and request review, please. |
ea7c54a
to
d08a832
Compare
22175e3
to
da4a172
Compare
d08a832
to
2bd436d
Compare
Failed in IT. Trying |
No reindex failures. Queues are all empty. |
Retrying IT passed after the early_reindex. |
IT for merge commit failed in develop as expected. Starting early_reindex. |
Merge build passed post-reindex 👍 |
#2824
Author
Fix:
for bugs) or there is a good reason why they're differentAuthor (reindex)
r
tag to commit title or this PR does not require reindexingreindex
label to PR or this PR does not require reindexingAuthor (freebies & chains)
chain
label to the blocking PR or this PR is not chained to another PRAuthor (upgrading)
u
tag to commit title or this PR does not require upgradingupgrade
label to PR or this PR does not require upgradingAuthor (requirements, before every review)
make requirements_update
or this PR leaves requirements*.txt, common.mk and Makefile untouchedR
tag to commit title or this PR leaves requirements*.txt untouchedreqs
label to PR or this PR leaves requirements*.txt untouchedAuthor (before every review)
make integration_test
passes in personal deployment or this PR does not touch functionality that could break the ITdevelop
, squashed old fixupsPrimary reviewer (after approval)
no demo
no sandbox
Operator (before pushing merge the commit)
reindex
label andr
commit title tagno demo
sandbox
label or PR is labeledno sandbox
no sandbox
sandbox
or this PR does not require reindexingsandbox
sandbox
or this PR does not require reindexingsandbox
Operator (after pushing the merge commit)
N reviews
labelling is accurateOperator (reindex)
dev
or this PR does not require reindexing or does not targetdev
dev
or this PR does not require reindexing or does not targetdev
prod
or this PR does not require reindexing or does not targetprod
prod
or this PR does not require reindexing or does not targetprod
Operator