Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive prefix from snapshot size (HumanCellAtlas/dcp2#17) #3488

Merged
merged 5 commits into from
Oct 3, 2021

Conversation

hannes-ucsc
Copy link
Member

@hannes-ucsc hannes-ucsc commented Oct 3, 2021

HumanCellAtlas/dcp2#17

Author

  • PR title references issue
  • PR title matches issue title (preceded by Fix: for bugs) or there is a good reason why they're different
  • Title of main commit references issue
  • PR is connected to Zenhub issue and description links to issue

Author (reindex)

  • Added r tag to commit title or this PR does not require reindexing
  • Added reindex label to PR or this PR does not require reindexing

Author (freebies & chains)

  • Freebies are blocked on this PR or there are no freebies in this PR
  • Freebies are referenced in commit titles or there are no freebies in this PR
  • This PR is blocked by previous PR in the chain or this PR is not chained to another PR
  • Added chain label to the blocking PR or this PR is not chained to another PR

Author (upgrading)

  • Documented upgrading of deployments in UPGRADING.rst or this PR does not require upgrading
  • Added u tag to commit title or this PR does not require upgrading
  • Added upgrade label to PR or this PR does not require upgrading
  • Added announcement to PR description or this PR does not require announcement
  • Added checklist items for additional operator tasks or this PR does not require additional tasks

Author (requirements, before every review)

  • Ran make requirements_update or this PR leaves requirements*.txt, common.mk and Makefile untouched
  • Added R tag to commit title or this PR leaves requirements*.txt untouched
  • Added reqs label to PR or this PR leaves requirements*.txt untouched

Author (before every review)

  • make integration_test passes in personal sandbox deployment or this PR does not touch functionality that could break the IT
  • Rebased branch on develop, squashed old fixups

Primary reviewer (after approval)

  • Commented in issue about demo expectations or labelled issue as no demo
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Moved ticket to Approved column
  • Assigned PR to an operator

Operator (before pushing merge the commit)

  • Checked reindex label and r commit title tag
  • Checked that demo expectations are clear or issue is labeled as no demo
  • Rebased and squashed branch
  • Sanity-checked history
  • Pushed PR branch to Github
  • Branch pushed to Gitlab and added sandbox label or PR is labeled no sandbox
  • Build passed in sandbox or PR is labeled no sandbox
  • Started reindex in sandbox or this PR does not require reindexing sandbox
  • Checked for failures in sandbox or this PR does not require reindexing sandbox
  • Added PR reference to merge commit title
  • Collected commit title tags in merge commit title
  • Moved linked issue to Merged column
  • Pushed merge commit to Github

Operator (after pushing the merge commit)

  • Made announcement requested by author or PR description does not contain an announcement
  • Moved freebies to Merged column or there are no freebies in this PR
  • Shortened the PR chain or this PR is not the base of another PR
  • Verified that N reviews labelling is accurate
  • Pushed merge commit to Gitlab or this changes can be pushed later, together with another PR
  • Deleted PR branch from Github and Gitlab

Operator (reindex)

  • Started reindex in dev or this PR does not require reindexing or does not target dev
  • Checked for failures in dev or this PR does not require reindexing or does not target dev
  • Started reindex in prod or this PR does not require reindexing or does not target prod
  • Checked for failures in prod or this PR does not require reindexing or does not target prod

Operator

  • Unassigned PR

@github-actions github-actions bot added the orange [process] Done by the Azul team label Oct 3, 2021
@hannes-ucsc hannes-ucsc force-pushed the issues/hannes/dcp2-17-dev-snapshots branch from e7ed3a1 to 74b4a0a Compare October 3, 2021 04:27
@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #3488 (7bd4d4e) into develop (ff56875) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3488   +/-   ##
========================================
  Coverage    82.02%   82.02%           
========================================
  Files          123      123           
  Lines        14417    14417           
========================================
  Hits         11825    11825           
  Misses        2592     2592           
Impacted Files Coverage Δ
src/azul/__init__.py 81.02% <ø> (ø)
src/azul/terra.py 63.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff56875...7bd4d4e. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 3, 2021

Coverage Status

Coverage remained the same at 82.265% when pulling 7bd4d4e on issues/hannes/dcp2-17-dev-snapshots into ff56875 on develop.

It was used by the HCA CLI which we don't use anymore. Setting it interferes with XDG-compliant utilities when run from a shell with `environment` sourced.
Make sure that all dev snapshots fit on one page.
@hannes-ucsc hannes-ucsc force-pushed the issues/hannes/dcp2-17-dev-snapshots branch from 2c45fd8 to 7bd4d4e Compare October 3, 2021 17:41
@hannes-ucsc hannes-ucsc self-assigned this Oct 3, 2021
@hannes-ucsc hannes-ucsc added reindex:dev [process] PR requires reindexing dev sandbox [process] Resolution is being verified in sandbox deployment labels Oct 3, 2021
@hannes-ucsc hannes-ucsc merged commit 074e0d8 into develop Oct 3, 2021
@hannes-ucsc hannes-ucsc added the 0 reviews [process] Lead didn't request any changes label Oct 3, 2021
@hannes-ucsc hannes-ucsc deleted the issues/hannes/dcp2-17-dev-snapshots branch October 3, 2021 22:28
@hannes-ucsc
Copy link
Member Author

1 failed notification, no failed tallies. Tracked in HumanCellAtlas/dcp2#48.

@hannes-ucsc hannes-ucsc removed their assignment Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 reviews [process] Lead didn't request any changes orange [process] Done by the Azul team reindex:dev [process] PR requires reindexing dev sandbox [process] Resolution is being verified in sandbox deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants