-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive prefix from snapshot size (HumanCellAtlas/dcp2#17) #3488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from d5c935f
hannes-ucsc
force-pushed
the
issues/hannes/dcp2-17-dev-snapshots
branch
from
October 3, 2021 04:27
e7ed3a1
to
74b4a0a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3488 +/- ##
========================================
Coverage 82.02% 82.02%
========================================
Files 123 123
Lines 14417 14417
========================================
Hits 11825 11825
Misses 2592 2592
Continue to review full report at Codecov.
|
It was used by the HCA CLI which we don't use anymore. Setting it interferes with XDG-compliant utilities when run from a shell with `environment` sourced.
Make sure that all dev snapshots fit on one page.
hannes-ucsc
force-pushed
the
issues/hannes/dcp2-17-dev-snapshots
branch
from
October 3, 2021 17:41
2c45fd8
to
7bd4d4e
Compare
hannes-ucsc
added
reindex:dev
[process] PR requires reindexing dev
sandbox
[process] Resolution is being verified in sandbox deployment
labels
Oct 3, 2021
1 failed notification, no failed tallies. Tracked in HumanCellAtlas/dcp2#48. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0 reviews
[process] Lead didn't request any changes
orange
[process] Done by the Azul team
reindex:dev
[process] PR requires reindexing dev
sandbox
[process] Resolution is being verified in sandbox deployment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HumanCellAtlas/dcp2#17
Author
Fix:
for bugs) or there is a good reason why they're differentAuthor (reindex)
r
tag to commit title or this PR does not require reindexingreindex
label to PR or this PR does not require reindexingAuthor (freebies & chains)
chain
label to the blocking PR or this PR is not chained to another PRAuthor (upgrading)
u
tag to commit title or this PR does not require upgradingupgrade
label to PR or this PR does not require upgradingAuthor (requirements, before every review)
make requirements_update
or this PR leaves requirements*.txt, common.mk and Makefile untouchedR
tag to commit title or this PR leaves requirements*.txt untouchedreqs
label to PR or this PR leaves requirements*.txt untouchedAuthor (before every review)
make integration_test
passes inpersonalsandbox deployment or this PR does not touch functionality that could break the ITdevelop
, squashed old fixupsPrimary reviewer (after approval)
no demo
no sandbox
Operator (before pushing merge the commit)
reindex
label andr
commit title tagno demo
sandbox
label or PR is labeledno sandbox
no sandbox
sandbox
or this PR does not require reindexingsandbox
sandbox
or this PR does not require reindexingsandbox
Operator (after pushing the merge commit)
N reviews
labelling is accurateOperator (reindex)
dev
or this PR does not require reindexing or does not targetdev
dev
or this PR does not require reindexing or does not targetdev
prod
or this PR does not require reindexing or does not targetprod
prod
or this PR does not require reindexing or does not targetprod
Operator