test: removed duplicate test, added missing tsdocs (#4124)

DataBiosphere · Sep 18, 2024 · 6633bed · 6633bed
1 parent dddee60
commit 6633bed
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 13 deletions.
diff --git a/explorer/e2e/anvil/anvil-filters.spec.ts b/explorer/e2e/anvil/anvil-filters.spec.ts
@@ -186,16 +186,6 @@ test('Check that selecting filters through the "Search all Filters" textbox work
   );
 });
 
-test('Check that selecting filters through the "Search all Filters" textbox works correctly on the Datasets tab', async ({
-  page,
-}) => {
-  await testSelectFiltersThroughSearchBar(
-    page,
-    ANVIL_TABS.DATASETS,
-    FILTER_INDEX_LIST_SHORT.map((x) => ANVIL_FILTER_NAMES[x])
-  );
-});
-
 test('Check that selecting filters through the "Search all Filters" textbox works correctly on the Donors tab', async ({
   page,
 }) => {

diff --git a/explorer/e2e/testFunctions.ts b/explorer/e2e/testFunctions.ts
@@ -232,7 +232,6 @@ export async function testSortCatalog(
   const columnNameArray = (
     await page.getByRole("columnheader").allInnerTexts()
   ).map((entry) => entry.trim());
-  console.log(columnNameArray);
   const columnObjectArray = Array.from(Object.values(tab.preselectedColumns));
   for (
     let columnPosition = 0;
@@ -420,10 +419,14 @@ export const getFirstFilterOptionLocator = (page: Page): Locator => {
     .first();
 };
 
+/**
+ * Gets the name of the filter option associated with a locator
+ * @param firstFilterOptionLocator - a Playwright locator to the filter option
+ * @returns the name of the filter option as a promise
+ */
 export const getFilterOptionName = async (
   firstFilterOptionLocator: Locator
 ): Promise<string> => {
-  console.log(await firstFilterOptionLocator.innerText());
   // Filter options display as "[text]\n[number]" , sometimes with extra whitespace, so we split on newlines and take the first non-empty string
   return (
     (await firstFilterOptionLocator.innerText())
@@ -434,7 +437,7 @@ export const getFilterOptionName = async (
 };
 
 /**
- * Cheks that selecting a specified filter is persistent across the tabs in tabOrder
+ * Checks that selecting a specified filter is persistent across the tabs in tabOrder
  * @param page - a Playwright page object
  * @param testFilterName - the name of the filter to check
  * @param tabOrder - the tabs to check, in order. The filter will be selected on the first tab.