Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix unwanted rerender from ErrorBoundary component (#3756) #3757

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix: fix unwanted rerender from ErrorBoundary component (#3756) #3757

merged 1 commit into from
Nov 8, 2023

Conversation

frano-m
Copy link
Contributor

@frano-m frano-m commented Nov 8, 2023

Ticket

Closes #3756.

Reviewers

@NoopDog.

Changes

  • Removed key with value asPath from ErrorBoundary component.

@frano-m frano-m requested a review from NoopDog November 8, 2023 08:13
@github-actions github-actions bot added the canary Done by the Clever Canary team label Nov 8, 2023
@NoopDog NoopDog merged commit addf7e6 into main Nov 8, 2023
3 checks passed
@NoopDog NoopDog deleted the fran/3756-error-boundary branch November 10, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoopDog NoopDog NoopDog approved these changes

Assignees

@NoopDog NoopDog

Labels
canary Done by the Clever Canary team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix unwanted rerender from ErrorBoundary component
2 participants
@frano-m @NoopDog