Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DUOS-2773] Truncate Table Cells #2378

Merged
merged 6 commits into from
Nov 13, 2023
Merged

[DUOS-2773] Truncate Table Cells #2378

merged 6 commits into from
Nov 13, 2023

Conversation

hams7504
Copy link
Contributor

@hams7504 hams7504 commented Nov 2, 2023

Addresses

https://broadworkbench.atlassian.net/browse/DUOS-2773

Summary

Have you read Terra's Contributing Guide lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@hams7504 hams7504 requested a review from a team as a code owner November 2, 2023 20:51
@hams7504 hams7504 marked this pull request as draft November 2, 2023 21:04
@hams7504 hams7504 marked this pull request as ready for review November 2, 2023 22:04
fboulnois
fboulnois approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @rushtong 's suggestion to make the property optional. Also, another idea:

src/components/CollapsibleTable.js Show resolved Hide resolved
fboulnois
fboulnois reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@fboulnois fboulnois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment:

src/components/CollapsibleTable.js Outdated Show resolved Hide resolved
@solideoglori solideoglori requested a review from rushtong November 7, 2023 21:24
rushtong
rushtong approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@hams7504 hams7504 merged commit 13ab5f7 into develop Nov 13, 2023
10 checks passed
@hams7504 hams7504 deleted the hm-duos-2773-truncate-rows branch November 13, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fboulnois fboulnois fboulnois approved these changes

@rushtong rushtong rushtong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hams7504 @rushtong @fboulnois