[doc] Update devnotes #2745
Merged
[doc] Update devnotes #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snf2ye
requested review from
s-rubenstein and
cinyecai
and removed request for
a team
fboulnois
approved these changes
Dec 5, 2024
I found it confusing that "env" was a boolean value instead of a variable that set the environment for the configs. But, glad to switch this back if others disagree.
snf2ye
force-pushed
the
sh/update-getting-started-docs
branch
from
0118b89 to
66fd044
Compare
"These additional spaces are added because not all markdown parsers recognize the triple backticks directly after a string." -fb
For sure, done! Hopefully I didn't miss any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully clarifies a few of these steps for new users getting started on duos ui. The changes reflect areas that I was confused by.
./render-configsand make more prominent in the instructions../render-configs. We can use the script as documentation for the steps so that we do not need to maintain this in two places../render-configsto differentiate between the parameters that set values (project) vs. boolean values (env->write_env)./render-configs.sh, so I've made that clear in the instructions. But, we may want to figure out how to run./scripts/render-configs.shdirectly.