Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AJ-1094: Initial Project Setup and Hello World CLI #1
AJ-1094: Initial Project Setup and Hello World CLI #1
Changes from 9 commits
e877db0
ccd077c
7194f92
67b3e75
1008712
8d530f6
7fd15a5
d0cc905
ffbbc44
8324e8f
2fb38b5
faf6fa1
b909cd9
2e041ac
41b8068
dac7e43
834ce97
460bece
fc87d7f
b693257
d494492
86bc394
81b7874
22927ac
7b4294a
6b41911
6fc95f3
93ce6cf
7371bb2
397ae31
9dc57a0
f519144
cda1397
c07d89c
e66e9ab
fb48d59
79ad761
41b05de
4870da5
e90b6cc
b18f455
82642ac
2017fad
f484b35
0aecde2
868ab14
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we will want to tag on every push to main - but I'm totally fine leaving this as-is and addressing in the future, once we have a better idea of what we DO want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I'm inclined to tag on every push to main, but agreed - let's leave as-is and we'll address it in the future once we've had a chance to discuss!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filename here is incorrect, I think. You want your plugin name to be scoped to a name specific to this project. So the filename (and plugin name, when used) should be something like
bio.terra.pfb.java-application-conventions
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I've renamed these convention files